Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-272] Updates to documentation #166

Merged
merged 2 commits into from
Jul 20, 2023

Conversation

JonoCX
Copy link
Member

@JonoCX JonoCX commented Jul 20, 2023

There are a few minor improvements that can be made to the documentation:

Getting Started

  • Remove references to matcha destroy full

References to the full command don't appear in the documentation.

  • Language stating that matcha will tell you what permissions you need
  • Docker as a prerequisite

Azure Permissions

  • Make it clear that it's Owner OR `Contributor + User Access Administrator

Deploying your first model

  • The focus is actually training and deploying your first model

The language is clear enough as training is stated throughout the page and it's about getting started with deploying more generally so I don't think this change needs to be made.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@JonoCX JonoCX self-assigned this Jul 20, 2023
@JonoCX JonoCX added the documentation Improvements or additions to documentation label Jul 20, 2023
Copy link
Member

@Christopher-Norman Christopher-Norman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minute grammar change

Copy link
Member

@Christopher-Norman Christopher-Norman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@JonoCX JonoCX merged commit 500608d into feature/bug-fixes-july-2023 Jul 20, 2023
@JonoCX JonoCX deleted the RPD-272-documentation-updates branch July 20, 2023 13:53
JonoCX added a commit that referenced this pull request Jul 28, 2023
* [RPD-261] [BUG] destroy leads to missing matcha config file error (#165)

* Update context managers to avoid erroring on destroy after remote bucket is removed

* Update docstrings

* Add tests for context managers new destroy parameter

* [RPD-272] Updates to documentation (#166)

* RPD-272 updates to pages based on ticket description

* RPD-272 updated permissions

* [RPD-276] [BUG] Turning analytics on causes hanging in the analytics service (#168)

* [RPD-271] [BUG] Fix orphaned NetworkWatcherRG resource group (#167)

* [RPD-279] [BUG] Automatically deal with stale states #170

* [RPD-273] Improvements to the `provision` user experience (#173)

* RPD-273 added a terraform state update function and minor improvements to terraform service

* RPD-273 updated typing and fixed pre-commit issues

* RPD-273 undoing a change to the gitignore

* RPD-273 updated docstrings + grammar

* RPD-272 updated typing on context manager for Spinner

* [RPD-274] [BUG] Fix inaccurate provisioning messages (#177)

* Update message on Terraform apply for clarity

* Update test with new message

* Update base_runner.py

* Fix test

* Revert message parameter to empty string

* [RPD-263] add inference of zenml version from environment (#178)

* function checking local zenml version.

* function checking local zenml version.

* function checking local zenml version.

* remove return from ds as there is none

---------

Co-authored-by: Jonathan Carlton <[email protected]>
Co-authored-by: KirsoppJ <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants