Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug Fixes July-2023 #169

Merged
merged 8 commits into from
Jul 28, 2023
Merged

Bug Fixes July-2023 #169

merged 8 commits into from
Jul 28, 2023

Conversation

Christopher-Norman
Copy link
Member

@Christopher-Norman Christopher-Norman commented Jul 21, 2023 •
edited
Loading

This PR includes various bug fixes and documentation improvements.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

Christopher-Norman and others added 4 commits July 20, 2023 13:43
@Christopher-Norman
[RPD-261] [BUG] destroy leads to missing matcha config file error (#165)
4cd63de 
* Update context managers to avoid erroring on destroy after remote bucket is removed

* Update docstrings

* Add tests for context managers new destroy parameter
@JonoCX
[RPD-272] Updates to documentation (#166)
500608d 
* RPD-272 updates to pages based on ticket description

* RPD-272 updated permissions
@Christopher-Norman
[RPD-276] [BUG] Turning analytics on causes hanging in the analytics …
a21ea29 
…service (#168)
@JonoCX
[RPD-271] [BUG] Fix orphaned NetworkWatcherRG resource group (#167)
f6804ad
@Christopher-Norman Christopher-Norman self-assigned this Jul 21, 2023
@Christopher-Norman Christopher-Norman added the bug Something isn't working label Jul 21, 2023
@Christopher-Norman Christopher-Norman added the documentation Improvements or additions to documentation label Jul 24, 2023
JonoCX and others added 2 commits July 26, 2023 14:44
@JonoCX
[RPD-273] Improvements to the provision user experience (#173)
c80823f 
* RPD-273 added a terraform state update function and minor improvements to terraform service

* RPD-273 updated typing and fixed pre-commit issues

* RPD-273 undoing a change to the gitignore

* RPD-273 updated docstrings + grammar

* RPD-272 updated typing on context manager for Spinner
@Christopher-Norman
[RPD-274] [BUG] Fix inaccurate provisioning messages (#177)
5acf210 
* Update message on Terraform apply for clarity

* Update test with new message

* Update base_runner.py

* Fix test

* Revert message parameter to empty string
@Christopher-Norman Christopher-Norman changed the title [WIP] Bug Fixes July-2023 Bug Fixes July-2023 Jul 27, 2023
@KirsoppJ
[RPD-263] add inference of zenml version from environment (#178)
6556495 
* function checking local zenml version.

* function checking local zenml version.

* function checking local zenml version.

* remove return from ds as there is none
@JonoCX JonoCX merged commit 215f84f into develop Jul 28, 2023
@JonoCX JonoCX deleted the feature/bug-fixes-july-2023 branch July 31, 2023 13:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@Christopher-Norman Christopher-Norman

Labels
bug Something isn't working documentation Improvements or additions to documentation
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Christopher-Norman @JonoCX @KirsoppJ