Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-239] Improve the way the UI handles latency when contacting Azure services #198

Merged
merged 1 commit into from
Aug 17, 2023

Conversation

swells2020
Copy link
Contributor

@swells2020 swells2020 commented Aug 16, 2023

This PR improves upon the unhandled latency experienced during the CLI provisioning stages by adding UI messages to each validation step that involves an external Azure API call.

This PR adds two messages to the validation functionality, one for the checking of the user-defined prefix and one for the validation of the resource group location.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@swells2020 swells2020 self-assigned this Aug 16, 2023
@swells2020 swells2020 changed the title [WIP] RPD-239 Improve the way the UI handles latency when contacting Azure services RPD-239 Improve the way the UI handles latency when contacting Azure services Aug 17, 2023
@swells2020 swells2020 changed the title RPD-239 Improve the way the UI handles latency when contacting Azure services [RPD-239] Improve the way the UI handles latency when contacting Azure services Aug 17, 2023
Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice one Callum

@swells2020 swells2020 merged commit c38910b into develop Aug 17, 2023
@swells2020 swells2020 deleted the RPD-239-improve-azure-latency-handling branch August 17, 2023 12:37
swells2020 added a commit that referenced this pull request Aug 24, 2023
* [RPD-239] Improve the way the UI handles latency when contacting Azure services (#198)

* [RPD-248] Add a basic example demonstrating how to use the API (#199)

* updates docs

* removes scratch.py

* fixes typos

* updates for comments

* adds cli command to cli module

* fix circular import (#201)

* bumping to version v0.2.9 for release

* adds tests

---------

Co-authored-by: KirsoppJ <[email protected]>
Co-authored-by: Jonathan Carlton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants