Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPD-305] fix circular import error #201

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

KirsoppJ
Copy link
Contributor

@KirsoppJ KirsoppJ commented Aug 23, 2023

Remove import of MatchaStateService, make provision and deprovision in BaseRunner abstract methods.

Checklist

Please ensure you have done the following:

  • I have read the CONTRIBUTING guide.
  • I have updated the documentation if required.
  • I have added tests which cover my changes.

Type of change

Tick all those that apply:

  • Bug Fix (non-breaking change, fixing an issue)
  • New feature (non-breaking change to add functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)
  • Other (add details above)

@KirsoppJ KirsoppJ added the bug Something isn't working label Aug 23, 2023
@KirsoppJ KirsoppJ self-assigned this Aug 23, 2023
Copy link
Member

@JonoCX JonoCX left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🦖

Copy link
Member

@Christopher-Norman Christopher-Norman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@KirsoppJ KirsoppJ merged commit 658eabc into develop Aug 23, 2023
@KirsoppJ KirsoppJ deleted the RPD-305-fix-circular-import-error branch August 23, 2023 12:10
swells2020 added a commit that referenced this pull request Aug 24, 2023
* [RPD-239] Improve the way the UI handles latency when contacting Azure services (#198)

* [RPD-248] Add a basic example demonstrating how to use the API (#199)

* updates docs

* removes scratch.py

* fixes typos

* updates for comments

* adds cli command to cli module

* fix circular import (#201)

* bumping to version v0.2.9 for release

* adds tests

---------

Co-authored-by: KirsoppJ <[email protected]>
Co-authored-by: Jonathan Carlton <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants