You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
When building for windows, some projects fail to add the icon to the exe file. Doesn't matter if building for x64 or x86 or when building from a different machine.
The project that it doesn't work on is my [email protected]
it has a structure that is something like
When building with a working dir of BeatList with fyne-cross windows ./cmd/gui it works fine and it generates the exe file, but it doesn't add the icon to the exe file.
The ico file is generated in the temp folder of fyne-cross but it just doesn't get applied to the exe.
I have another project I'm working with a very similar structure, only difference being that the base dir and the dir in cmd have the same name, it is working perfectly and the icon gets applied to the exe, so I tried renaming the folder in this project to be the same as the base dir to no effect.
If I go into the gui dir and use fyne package then it works fine and generates an icon with the exe,
in the end
I did manage to get fyne cross to compile the exe with an icon, but I had to make another go mod file in the gui dir and move the Icon png to the gui dir (v0.1.3)
note: for the full build script I used you can check the bash script in the scripts dir on both versions
The windows resource file (syso) need to be into the package root to be linked automatically by the compiler.
This commit copies the syso file into the package root after it is created.
Fixesfyne-io#66
When building for windows, some projects fail to add the icon to the exe file. Doesn't matter if building for x64 or x86 or when building from a different machine.
The project that it doesn't work on is my [email protected]
it has a structure that is something like
When building with a working dir of BeatList with
fyne-cross windows ./cmd/gui
it works fine and it generates the exe file, but it doesn't add the icon to the exe file.The ico file is generated in the temp folder of fyne-cross but it just doesn't get applied to the exe.
I have another project I'm working with a very similar structure, only difference being that the base dir and the dir in cmd have the same name, it is working perfectly and the icon gets applied to the exe, so I tried renaming the folder in this project to be the same as the base dir to no effect.
If I go into the gui dir and use
fyne package
then it works fine and generates an icon with the exe,in the end
I did manage to get fyne cross to compile the exe with an icon, but I had to make another go mod file in the gui dir and move the Icon png to the gui dir (v0.1.3)
note: for the full build script I used you can check the bash script in the scripts dir on both versions
fyne-cross version v1.1.0
fyne version v2.0.4
I talked about this in the gophers discord as well and @andydotxyz mentioned a person with the same issue on the slack
The text was updated successfully, but these errors were encountered: