Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Window resource flle need to be placed into the package root to be linked #79

Merged
merged 3 commits into from
Oct 7, 2021

Conversation

lucor
Copy link
Member

@lucor lucor commented Oct 6, 2021

Description:

The windows resource file (syso) need to be into the package root to be linked automatically by the compiler.

This PR copies the syso file into the package root after it is created.

Fixes #66

Checklist:

  • Tests included.
  • Lint and formatter run with no errors.
  • Tests all pass.

lucor added 3 commits October 6, 2021 20:56
The windows resource file (syso) need to be into the package root to be linked automatically by the compiler.

This commit copies the syso file into the package root after it is created.

Fixes fyne-io#66
@andydotxyz
Copy link
Member

Was this based on the wrong branch? It seems like a lot of unrelated changes.

@lucor
Copy link
Member Author

lucor commented Oct 7, 2021

It also merges master in develop, hence the other changes.
The commits related to this PR are ea49d44 and 2e657ca

@lucor lucor merged commit f208c48 into fyne-io:develop Oct 7, 2021
@lucor lucor deleted the fix/windows-icon-packaging branch October 7, 2021 16:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants