Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use rgba8 as downgrade shadow texture #1033

Merged
merged 1 commit into from
Sep 11, 2022
Merged

Use rgba8 as downgrade shadow texture #1033

merged 1 commit into from
Sep 11, 2022

Conversation

yangfengzzz
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

What kind of change does this PR introduce? (Bug fix, feature, docs update, ...)

What is the current behavior? (You can also link to an open issue here)

What is the new behavior (if this is a feature change)?

Does this PR introduce a breaking change? (What changes might users need to make in their application due to this PR?)

Other information:

@yangfengzzz yangfengzzz self-assigned this Sep 11, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #1033 (3892b68) into dev/0.9 (1bc314f) will increase coverage by 0.01%.
The diff coverage is 0.00%.

@@             Coverage Diff             @@
##           dev/0.9    #1033      +/-   ##
===========================================
+ Coverage    33.23%   33.24%   +0.01%     
===========================================
  Files          331      331              
  Lines        14713    14713              
  Branches      2257     2257              
===========================================
+ Hits          4890     4892       +2     
  Misses        9282     9282              
+ Partials       541      539       -2     
Impacted Files Coverage Δ
packages/core/src/shadow/ShadowUtils.ts 1.51% <0.00%> (ø)
packages/math/src/Color.ts 78.78% <0.00%> (+3.03%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@GuoLei1990 GuoLei1990 added ignore for release ignore for release Rendering Rendering related functions labels Sep 11, 2022
@GuoLei1990 GuoLei1990 added this to the 0.9 milestone Sep 11, 2022
@GuoLei1990 GuoLei1990 merged commit f6567e6 into galacean:dev/0.9 Sep 11, 2022
@GuoLei1990 GuoLei1990 changed the title fix: use rgba8 as downgrade shadow texture Use rgba8 as downgrade shadow texture Sep 11, 2022
GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Sep 14, 2022
…rData-improve

* commit 'f34d3ace905a74861fb2852afa0a2ce99fe3032d':
  Fix text renderer element not render state (galacean#1043)
  Shader support multi shader pass (galacean#948)
  v0.9.0-alpha.4
  fix: use rgba8 as downgrade shadow texture (galacean#1033)
  v0.9.0-alpha.3
  shadowMap using color texture when platform not support depthTexture (galacean#1029)
  Fix `SkinnedMeshRenderer` clone bug (galacean#1028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ignore for release ignore for release Rendering Rendering related functions
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants