Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix text renderer element not render state #1043

Merged
merged 17 commits into from
Sep 14, 2022

Conversation

singlecoder
Copy link
Member

Please check if the PR fulfills these requirements

  • The commit message follows our guidelines
  • Tests for the changes have been added (for bug fixes / features)
  • Docs have been added / updated (for bug fixes / features)

@singlecoder singlecoder added the text 2D text system label Sep 14, 2022
@singlecoder singlecoder added this to the 0.9 milestone Sep 14, 2022
@singlecoder singlecoder self-assigned this Sep 14, 2022
@codecov-commenter
Copy link

codecov-commenter commented Sep 14, 2022

Codecov Report

Base: 33.27% // Head: 33.27% // Decreases project coverage by -0.00% ⚠️

Coverage data is based on head (02c1411) compared to base (a69f9e4).
Patch coverage: 0.00% of modified lines in pull request are covered.

Additional details and impacted files
@@             Coverage Diff             @@
##           dev/0.9    #1043      +/-   ##
===========================================
- Coverage    33.27%   33.27%   -0.01%     
===========================================
  Files          332      332              
  Lines        14777    14778       +1     
  Branches      2266     2266              
===========================================
  Hits          4917     4917              
- Misses        9310     9311       +1     
  Partials       550      550              
Impacted Files Coverage Δ
packages/core/src/2d/text/TextRenderer.ts 9.91% <0.00%> (-0.05%) ⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

☔ View full report at Codecov.
📢 Do you have feedback about the report comment? Let us know in this issue.

@GuoLei1990 GuoLei1990 changed the title fix(text): fix text renderer element not render state Fix text renderer element not render state Sep 14, 2022
@GuoLei1990 GuoLei1990 added bug Something isn't working ignore for release ignore for release labels Sep 14, 2022
@GuoLei1990 GuoLei1990 merged commit f34d3ac into galacean:dev/0.9 Sep 14, 2022
Copy link
Collaborator

@cptbtptpbcptdtptp cptbtptpbcptdtptp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1
感觉 local 这层是不是还可以做一个缓存,比如说保存一个 localMatrix 来表示居左居右,因为 _updateLocalData 这个函数代价比较大,而且生成以后基本不会改变。

GuoLei1990 added a commit to GuoLei1990/galacean-engine that referenced this pull request Sep 14, 2022
…rData-improve

* commit 'f34d3ace905a74861fb2852afa0a2ce99fe3032d':
  Fix text renderer element not render state (galacean#1043)
  Shader support multi shader pass (galacean#948)
  v0.9.0-alpha.4
  fix: use rgba8 as downgrade shadow texture (galacean#1033)
  v0.9.0-alpha.3
  shadowMap using color texture when platform not support depthTexture (galacean#1029)
  Fix `SkinnedMeshRenderer` clone bug (galacean#1028)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working ignore for release ignore for release text 2D text system
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants