-
-
Notifications
You must be signed in to change notification settings - Fork 310
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix text renderer element not render state #1043
Conversation
* fix(text): text can not update error
Codecov ReportBase: 33.27% // Head: 33.27% // Decreases project coverage by
Additional details and impacted files@@ Coverage Diff @@
## dev/0.9 #1043 +/- ##
===========================================
- Coverage 33.27% 33.27% -0.01%
===========================================
Files 332 332
Lines 14777 14778 +1
Branches 2266 2266
===========================================
Hits 4917 4917
- Misses 9310 9311 +1
Partials 550 550
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. ☔ View full report at Codecov. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
感觉 local 这层是不是还可以做一个缓存,比如说保存一个 localMatrix 来表示居左居右,因为 _updateLocalData 这个函数代价比较大,而且生成以后基本不会改变。
…rData-improve * commit 'f34d3ace905a74861fb2852afa0a2ce99fe3032d': Fix text renderer element not render state (galacean#1043) Shader support multi shader pass (galacean#948) v0.9.0-alpha.4 fix: use rgba8 as downgrade shadow texture (galacean#1033) v0.9.0-alpha.3 shadowMap using color texture when platform not support depthTexture (galacean#1029) Fix `SkinnedMeshRenderer` clone bug (galacean#1028)
Please check if the PR fulfills these requirements