Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Added new prow job to run e2e tests of etcd-druid with feature gates turned on #798

Merged
merged 2 commits into from
Jul 31, 2023
Merged

Added new prow job to run e2e tests of etcd-druid with feature gates turned on #798

merged 2 commits into from
Jul 31, 2023

Conversation

aaronfern
Copy link
Contributor

What this PR does / why we need it:
This PR introduces a new prow job pull-etcd-druid-e2e-kind-alpha-features-true that runs etcd-druid e2e tests with all feature gates turned on

Which issue(s) this PR fixes:
Fixes partially gardener/etcd-druid#643

Special notes for your reviewer:

@gardener-prow gardener-prow bot requested review from plkokanov and ScheererJ July 24, 2023 14:40
@gardener-prow gardener-prow bot added do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. labels Jul 24, 2023
@aaronfern
Copy link
Contributor Author

/hold
To be merged only after etcd-druid:v0.19.0 has been releases.
I will notify here when the release has happened. In the meantime, PR review can proceed.

@gardener-prow gardener-prow bot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 24, 2023
@aaronfern
Copy link
Contributor Author

Thanks for your review @oliver-goetz!
I've addressed your comments

oliver-goetz
oliver-goetz approved these changes Jul 26, 2023
View reviewed changes
Copy link
Member

@oliver-goetz oliver-goetz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/kind enhancement

/lgtm

@gardener-prow gardener-prow bot added kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. labels Jul 26, 2023
@gardener-prow
Copy link

gardener-prow bot commented Jul 26, 2023

LGTM label has been added.

Git tree hash: b0054b47efcc26c5a2d7c37e0a6c2459ceb56c3d

@gardener-prow gardener-prow bot added approved Indicates a PR has been approved by an approver from all required OWNERS files. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 26, 2023
shreyas-s-rao
shreyas-s-rao approved these changes Jul 26, 2023
View reviewed changes
Copy link
Contributor

@shreyas-s-rao shreyas-s-rao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/lgtm

@gardener-prow
Copy link

gardener-prow bot commented Jul 26, 2023

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: oliver-goetz, shreyas-s-rao

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@shreyas-s-rao
Copy link
Contributor

We need not wait until the etcd-druid release is made, since the prow job can run on PRs as soon as this PR is merged to master.

@aaronfern
Copy link
Contributor Author

This PR can now be merged as gardener/etcd-druid#646 is ready to be merged and this prow job being enabled will be a good validator for merging the druid PR
/unhold

@gardener-prow gardener-prow bot removed the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 31, 2023
@gardener-prow gardener-prow bot merged commit b4a396a into gardener:master Jul 31, 2023
@gardener-prow
Copy link

gardener-prow bot commented Jul 31, 2023

@aaronfern: Updated the job-config configmap in namespace prow at cluster gardener-prow-trusted using the following files:

  • key druid-e2e-kind-alpha-features.yaml using file config/jobs/etcd-druid/druid-e2e-kind-alpha-features.yaml

In response to this:

What this PR does / why we need it:
This PR introduces a new prow job pull-etcd-druid-e2e-kind-alpha-features-true that runs etcd-druid e2e tests with all feature gates turned on

Which issue(s) this PR fixes:
Fixes partially gardener/etcd-druid#643

Special notes for your reviewer:

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes/test-infra repository.

@shreyas-s-rao shreyas-s-rao mentioned this pull request Jul 31, 2023
Closed
16 tasks
@aaronfern aaronfern deleted the feature_gate_druid_job branch August 1, 2023 06:30
@ishan16696 ishan16696 mentioned this pull request Jan 3, 2024
Closed
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@shreyas-s-rao shreyas-s-rao shreyas-s-rao approved these changes

@oliver-goetz oliver-goetz oliver-goetz approved these changes

@plkokanov plkokanov Awaiting requested review from plkokanov

@ScheererJ ScheererJ Awaiting requested review from ScheererJ

Assignees

@shreyas-s-rao shreyas-s-rao

@oliver-goetz oliver-goetz

Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. cla: yes Indicates the PR's author has signed the cla-assistant.io CLA. kind/enhancement Enhancement, improvement, extension lgtm Indicates that a PR is ready to be merged. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@aaronfern @shreyas-s-rao @oliver-goetz