Introduced feature gates in etcd druid and added `UseEtcdWrapper` feature gate #646

aaronfern · 2023-07-19T17:31:37Z

How to categorize this PR?

/area disaster-recovery
/kind enhancement

What this PR does / why we need it:
This PR achieves the following

Introduce feature gates in etcd-druid. Now large or experimental changes can be made available via a feature gate to only those who opt for them
A new feature gate UseEtcdWrapper has been added. Enabling this feature gates instructs to deploy an etcd-wrapper container along with a distroless etcd-backup-restore conatainer via the statefulset instead of the etcd-custom-image container along with a previous version of the etcd-backup-restore container based on the alpine distro

Which issue(s) this PR fixes:
Fixes partially #643

Special notes for your reviewer:
This PR is to be merged only after a release of etcd-custom-image is made

Release note:

Feature gates have been introduced in etcd-druid, and can be specified using CLI flag `--feature-gate`.

`UseEtcdWrapper` feature gate has been introduced to allow users to opt for the new [etcd-wrapper](https://github.com/gardener/etcd-wrapper) image.

…ture gate

Co-authored-by: Seshachalam <[email protected]>

shreyas-s-rao

@aaronfern thanks for the PR! I've tested the changes and it works well.
Please rename all occurrences of feature flags to feature gates since we no longer use individual CLI flags for setting each feature, but rather use a single --feature-gates flag for this, similar to upstream k8s feature gates.

Change release notes to:

feature operator

Feature gates have been introduced in etcd-druid, and can be specified using CLI flag `--feature-gate`.

feature operator

`UseEtcdWrapper` feature gate has been introduced to allow users to opt for the new [etcd-wrapper](https://github.com/gardener/etcd-wrapper) image.

Also update PR description to say that this PR partially fixes #643

docs/deployment/feature-flags.md

charts/druid/templates/controller-deployment.yaml

main.go

controllers/etcd/config.go

pkg/component/etcd/statefulset/statefulset.go

pkg/component/etcd/statefulset/values_helper.go

Co-authored-by: Shreyas Rao <[email protected]>

seshachalam-yv

Overall looks good to me
/lgtm

shreyas-s-rao

/lgtm

shreyas-s-rao · 2023-07-28T16:55:57Z

/test pull-etcd-druid-e2e-kind

shreyas-s-rao · 2023-07-28T19:41:47Z

@aaronfern I ran the e2e tests locally with feature gates enabled, and I see that some of the tests fail since they are timing out. I've attached the test logs here.

e2e-test-feature-gates.log

I see that the issue is resolved by doubling the values for timeouts singleNodeEtcdTimeout and multiNodeEtcdTimeout in the e2e tests. After this I ran the e2e test again and had a flake as well. Attaching logs from two runs of e2e tests, where one passed and one failed. PTAL

e2e-test-feature-gates-changed-passed.log
e2e-test-feature-gates-changed-failed.log

Please make the changes in this PR before we merge it. Thanks!

shreyas-s-rao · 2023-07-28T19:43:09Z

/hold until e2e tests when feature-gates are enabled, are fixed.
I suspect it could be due to the additional init container that takes some time to run, in addition to the image pull time.

aaronfern · 2023-07-31T10:15:32Z

/test pull-etcd-druid-e2e-kind-alpha-features

aaronfern · 2023-07-31T10:44:20Z

/test pull-etcd-druid-e2e-kind-alpha-features

aaronfern · 2023-07-31T11:04:47Z

/test pull-etcd-druid-e2e-kind-alpha-features

shreyas-s-rao · 2023-07-31T13:20:07Z

/unhold as e2e tests are passing with feature gates enabled, as can be seen from the prow job pull-etcd-druid-e2e-kind-alpha-features.

[WIP] Introduce feature flags for druid

95e07f8

aaronfern requested a review from a team as a code owner July 19, 2023 17:31

aaronfern force-pushed the feature-flag branch from 1e7a80f to 6fe3b79 Compare July 19, 2023 17:48

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 19, 2023

Introduced feature gate for etcd druid and added 'UseEtcdWrapper' fea…

8cd7a51

…ture gate

aaronfern force-pushed the feature-flag branch from 6fe3b79 to 8cd7a51 Compare July 19, 2023 18:05

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2023

gardener-robot-ci-1 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 19, 2023

Added suport for druid to be deployed from charts with feature gates

269dc60

Co-authored-by: Seshachalam <[email protected]>

gardener-robot added size/xl Size of pull request is huge (see gardener-robot robot/bots/size.py) and removed size/l Size of pull request is large (see gardener-robot robot/bots/size.py) labels Jul 21, 2023

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2023

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 21, 2023

shreyas-s-rao requested changes Jul 22, 2023

View reviewed changes

gardener-robot added the needs/changes Needs (more) changes label Jul 22, 2023

shreyas-s-rao assigned aaronfern Jul 22, 2023

gardener-robot-ci-3 added reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) and removed reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) labels Jul 24, 2023

Addressed review comments

01a12fc

Co-authored-by: Shreyas Rao <[email protected]>

aaronfern force-pushed the feature-flag branch from 717a247 to 01a12fc Compare July 24, 2023 08:08

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 24, 2023

seshachalam-yv approved these changes Jul 27, 2023

View reviewed changes

shreyas-s-rao approved these changes Jul 27, 2023

View reviewed changes

gardener-robot added needs/second-opinion Needs second review by someone else and removed reviewed/lgtm Has approval for merging labels Jul 28, 2023

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2023

aaronfern force-pushed the feature-flag branch from 0927555 to ce0b7b3 Compare July 28, 2023 16:21

gardener-robot-ci-2 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2023

Updated etcd custom image

efee6ee

aaronfern force-pushed the feature-flag branch from ce0b7b3 to efee6ee Compare July 28, 2023 16:21

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2023

gardener-robot-ci-3 added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2023

gardener-robot-ci-2 removed the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 28, 2023

shreyas-s-rao mentioned this pull request Jul 28, 2023

Added new prow job to run e2e tests of etcd-druid with feature gates turned on gardener/ci-infra#798

Merged

gardener-robot added the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 28, 2023

aaronfern added the reviewed/ok-to-test Has approval for testing (check PR in detail before setting this label because PR is run on CI/CD) label Jul 31, 2023

gardener-robot removed the reviewed/do-not-merge Has no approval for merging as it may break things, be of poor quality or have (ext.) dependencies label Jul 31, 2023

shreyas-s-rao merged commit d391910 into gardener:master Jul 31, 2023

gardener-robot added the status/closed Issue is closed (either delivered or triaged) label Jul 31, 2023

shreyas-s-rao mentioned this pull request Jul 31, 2023

[Feature] Introduce feature gates concept, starting with UseEtcdWrapper #643

Closed

16 tasks

shreyas-s-rao assigned aaronfern and unassigned abdasgupta, shreyas-s-rao and seshachalam-yv Jan 17, 2024

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Introduced feature gates in etcd druid and added `UseEtcdWrapper` feature gate #646

Introduced feature gates in etcd druid and added `UseEtcdWrapper` feature gate #646

aaronfern commented Jul 19, 2023 •

edited

Loading

shreyas-s-rao left a comment

seshachalam-yv left a comment

shreyas-s-rao left a comment

shreyas-s-rao commented Jul 28, 2023

shreyas-s-rao commented Jul 28, 2023

shreyas-s-rao commented Jul 28, 2023

aaronfern commented Jul 31, 2023

aaronfern commented Jul 31, 2023

aaronfern commented Jul 31, 2023

shreyas-s-rao commented Jul 31, 2023 •

edited

Loading

Introduced feature gates in etcd druid and added UseEtcdWrapper feature gate #646

Introduced feature gates in etcd druid and added UseEtcdWrapper feature gate #646

Conversation

aaronfern commented Jul 19, 2023 • edited Loading

shreyas-s-rao left a comment

Choose a reason for hiding this comment

seshachalam-yv left a comment

Choose a reason for hiding this comment

shreyas-s-rao left a comment

Choose a reason for hiding this comment

shreyas-s-rao commented Jul 28, 2023

shreyas-s-rao commented Jul 28, 2023

shreyas-s-rao commented Jul 28, 2023

aaronfern commented Jul 31, 2023

aaronfern commented Jul 31, 2023

aaronfern commented Jul 31, 2023

shreyas-s-rao commented Jul 31, 2023 • edited Loading

Introduced feature gates in etcd druid and added `UseEtcdWrapper` feature gate #646

Introduced feature gates in etcd druid and added `UseEtcdWrapper` feature gate #646

aaronfern commented Jul 19, 2023 •

edited

Loading

shreyas-s-rao commented Jul 31, 2023 •

edited

Loading