Implement Configurable Retention Period for Delta Snapshots #640
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit introduces a new parameter, `delta-snapshot-retention-period`, in the `SnapshotterConfig`, allowing users to customize the retention period for delta snapshots. The garbage collection function `GarbageCollectDeltaSnapshots` is modified to use this new setting, ensuring delta snapshots within the user-specified period are not deleted.
gardener-robot
added
needs/review
gardener-robot-ci-2
added
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-2
removed
the
reviewed/ok-to-test
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot-ci-3
removed
the
reviewed/ok-to-test
aaronfern
requested changes
Jul 7, 2023
- Improved grammar and phrasing for better readability. - Fixed doc string for 'GarbageCollectDeltaSnapshots' function.
gardener-robot-ci-3
added
reviewed/ok-to-test
aaronfern
requested changes
Jul 13, 2023
There was a problem hiding this comment.
Thanks for addressing my comments @seshachalam-yv!
It looks good, just one last comment about the tests. Please address that
gardener-robot-ci-3
added
reviewed/ok-to-test
Co-authored-by: Aaron Francis Fernandes <[email protected]> Update snapshotter_test.go with additional safety checks
seshachalam-yv
force-pushed
the
feature/configurable-delta-snapshot-retention
branch
from
4624166 to
89483ec
Compare
gardener-robot-ci-3
added
the
reviewed/ok-to-test
gardener-robot
removed
the
needs/second-opinion
gardener-robot-ci-1
added
reviewed/ok-to-test
shreyas-s-rao
requested changes
Jul 22, 2023
There was a problem hiding this comment.
@seshachalam-yv thanks for the PR as well as detailed doc. I have few suggestions, but overall logic looks good.
Co-authored-by: Shreyas Rao <[email protected]>
gardener-robot
added
needs/second-opinion
gardener-robot-ci-1
added
reviewed/ok-to-test
gardener-robot-ci-3
added
reviewed/ok-to-test
seshachalam-yv
force-pushed
the
feature/configurable-delta-snapshot-retention
branch
from
6d6eaf7 to
182d3dd
Compare
gardener-robot-ci-3
added
reviewed/ok-to-test
shreyas-s-rao
approved these changes
Jul 26, 2023
There was a problem hiding this comment.
@seshachalam-yv thank for making all the requested changes. No further comments.
Please create the two new issues as specified in the comments.
/lgtm
This was referenced Jul 27, 2023
|
The integration test is failing due to a CI infrastructure issue. However, I have run it locally and it passed successfully, as shown in this test-output.txt. Consequently, I am proceeding to merge this PR. |
gardener-robot
added
the
status/closed
seshachalam-yv
added a commit
to seshachalam-yv/etcd-backup-restore
that referenced
this pull request
Oct 11, 2023
…#640) * `feat: Implement configurable retention period for delta snapshots` This commit introduces a new parameter, `delta-snapshot-retention-period`, in the `SnapshotterConfig`, allowing users to customize the retention period for delta snapshots. The garbage collection function `GarbageCollectDeltaSnapshots` is modified to use this new setting, ensuring delta snapshots within the user-specified period are not deleted. * Fixed lint error * Fixed failing unit test * Refactor and improve unit tests for GarbageCollectDeltaSnapshots * Addressed PR feedback - Improved grammar and phrasing for better readability. - Fixed doc string for 'GarbageCollectDeltaSnapshots' function. * Update snapshotter_test.go with additional safety checks Co-authored-by: Aaron Francis Fernandes <[email protected]> Update snapshotter_test.go with additional safety checks * Apply suggestions from code review Co-authored-by: Shreyas Rao <[email protected]> * Addressed review feedback --------- Co-authored-by: Shreyas Rao <[email protected]>
seshachalam-yv
added a commit
that referenced
this pull request
Oct 12, 2023
) * `feat: Implement configurable retention period for delta snapshots` This commit introduces a new parameter, `delta-snapshot-retention-period`, in the `SnapshotterConfig`, allowing users to customize the retention period for delta snapshots. --------- Co-authored-by: Shreyas Rao <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
This PR resolves the request for a configurable retention period for delta snapshots. This feature aims to provide users with more flexibility in preserving delta snapshots for both GC policies (
ExponentialandLimit-Based)Changes introduced in this PR include:
delta-snapshot-retention-periodparameter in theSnapshotterConfigto allow for the customization of the retention period for delta snapshots. This new setting can be adjusted via command-line flags.GarbageCollectDeltaSnapshotsfunction, formerlygarbageCollectDeltaSnapshots, to utilize theDeltaSnapshotRetentionPeriodparameter when identifying delta snapshots for deletion. This change ensures that delta snapshots within the user-specified retention period will not be deleted.doc/usage/garbage_collection.md) to include a detailed explanation of the newdelta-snapshot-retention-periodsetting.GarbageCollectDeltaSnapshotsto add unit tests.snapshotter_test.goWhich issue(s) this PR fixes:
Fixes #639
Special notes for your reviewer:
Release note: