[rel-v0.24] Implement Configurable Retention Period for Delta Snapshots #640 #669
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…#640) * `feat: Implement configurable retention period for delta snapshots` This commit introduces a new parameter, `delta-snapshot-retention-period`, in the `SnapshotterConfig`, allowing users to customize the retention period for delta snapshots. The garbage collection function `GarbageCollectDeltaSnapshots` is modified to use this new setting, ensuring delta snapshots within the user-specified period are not deleted. * Fixed lint error * Fixed failing unit test * Refactor and improve unit tests for GarbageCollectDeltaSnapshots * Addressed PR feedback - Improved grammar and phrasing for better readability. - Fixed doc string for 'GarbageCollectDeltaSnapshots' function. * Update snapshotter_test.go with additional safety checks Co-authored-by: Aaron Francis Fernandes <[email protected]> Update snapshotter_test.go with additional safety checks * Apply suggestions from code review Co-authored-by: Shreyas Rao <[email protected]> * Addressed review feedback --------- Co-authored-by: Shreyas Rao <[email protected]>
gardener-robot-ci-1
added
the
reviewed/ok-to-test
gardener-robot
added
size/xl
gardener-robot-ci-1
added
needs/ok-to-test
gardener-robot
added
reviewed/lgtm
gardener-robot-ci-2
added
the
reviewed/ok-to-test
gardener-robot
added
the
status/closed
shreyas-s-rao
changed the title
shreyas-s-rao
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What this PR does / why we need it:
Cherry-pick of #640
This PR resolves the request for a configurable retention period for delta snapshots. This feature aims to provide users with more flexibility in preserving delta snapshots for both GC policies (
ExponentialandLimit-Based)Changes introduced in this PR include:
delta-snapshot-retention-periodparameter in theSnapshotterConfigto allow for the customization of the retention period for delta snapshots. This new setting can be adjusted via command-line flags.GarbageCollectDeltaSnapshotsfunction, formerlygarbageCollectDeltaSnapshots, to utilize theDeltaSnapshotRetentionPeriodparameter when identifying delta snapshots for deletion. This change ensures that delta snapshots within the user-specified retention period will not be deleted.doc/usage/garbage_collection.md) to include a detailed explanation of the newdelta-snapshot-retention-periodsetting.GarbageCollectDeltaSnapshotsto add unit tests.snapshotter_test.goWhich issue(s) this PR fixes:
Special notes for your reviewer:
Release note: