Skip to content
This repository was archived by the owner on Jan 20, 2025. It is now read-only.

New translation: schema-sift.md #233

Merged
merged 8 commits into from
Apr 28, 2020

Conversation

felipefbs
Copy link
Contributor

@felipefbs felipefbs commented Apr 9, 2020

Qual o objetivo dessa pull request?

  • Adição de uma nova tradução
  • Correção em uma tradução existente

Qual arquivo foi traduzido/corrigido?

schema-sift.md

Algum comentário em relação a tradução?

@felipefbs felipefbs requested review from iaurg and jessescn as code owners April 9, 2020 21:09
@felipefbs felipefbs changed the title Traducao schema sift.md New translation: schema-sift.md Apr 9, 2020
iaurg
iaurg previously requested changes Apr 13, 2020
Copy link
Contributor

@iaurg iaurg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Obrigado por contribuir @felipefbs, marquei alguns pontos e detalhes para você verificar. Veja o que acha. ⚔️

@felipefbs
Copy link
Contributor Author

fiz as alterações sugeridas pelos @iaurg.

@henriquepw henriquepw added the /docs File refering to /docs directory label Apr 13, 2020
@iaurg iaurg requested a review from henriquepw April 13, 2020 18:59
Copy link
Contributor

@henriquepw henriquepw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 Obrigado @felipefbs pela sua contribuição!

A tradução está Boa, achei apenas uns espaços há mais em um parágrafo, talvez eu tenha deixado passar outros, da uma lida de novo para ver se acha algum.

henriquepw
henriquepw previously approved these changes Apr 13, 2020
henriquepw
henriquepw previously approved these changes Apr 15, 2020
Copy link
Contributor

@thayannevls thayannevls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Muito obrigada pela contribuição! 🎉

Adicionei algumas sugestões, a maioria por conta que em alguns cantos você usou nós e em outros nodes, se puder manter um padrão, sugiro pesquisar no arquivo e mudas todas as ocorrências de nodes pra nós.

@felipefbs
Copy link
Contributor Author

Fiz as correções sugeridas pela @thayannevls. Realmente havia não tinha percebido o tanto de "nós" que tinha. Como falei acho melhor ser o mesmo termo do original, pois já é um termo conhecido por aqui também.

Copy link
Contributor

@thayannevls thayannevls left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oie @felipefbs 😃 desculpa a demora, obrigada pelas correções. Coloquei alguns nitpick pra consertar aqui, mas de resto tá tudo ótimo

@felipefbs
Copy link
Contributor Author

Fiz os ajustes sugeridos pela @thayannevls :)

@henriquepw henriquepw requested a review from thayannevls April 24, 2020 03:06
@thayannevls thayannevls requested review from jessescn and iaurg April 28, 2020 16:14
@jessescn jessescn dismissed iaurg’s stale review April 28, 2020 19:52

already fixed

@jessescn jessescn merged commit d81181d into gatsbyjs:master Apr 28, 2020
@gatsbot
Copy link

gatsbot bot commented Apr 28, 2020

Holy buckets, @felipefbs — we just merged your PR to Gatsby! 💪💜

Gatsby is built by awesome people like you. Let us say “thanks” in two ways:

  1. We’d like to send you some Gatsby swag. As a token of our appreciation, you can go to the Gatsby Swag Store and log in with your GitHub account to get a coupon code good for one free piece of swag. We’ve got Gatsby t-shirts, stickers, hats, scrunchies, and much more. (You can also unlock even more free swag with 5 contributions — wink wink nudge nudge.) See gatsby.dev/swag for details.
  2. We just invited you to join the Gatsby organization on GitHub. This will add you to our team of maintainers. Accept the invite by visiting https://github.com/orgs/gatsbyjs/invitation. By joining the team, you’ll be able to label issues, review pull requests, and merge approved pull requests.

If there’s anything we can do to help, please don’t hesitate to reach out to us: tweet at @gatsbyjs and we’ll come a-runnin’.

Thanks again!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
/docs File refering to /docs directory
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants