fix(wordpress): ensure all file links are rewritten (#32679)

* fix(wordpress): ensure all file links are rewritten - in the case of either having a small `schema.perPage` setting or many many referenced resources on a single page only the first page of links were properly rewritten - now we ensure that all pages are fully processed until we resolve the promise - this is an improved recommit of #31652 fixes #31646 Co-authored-by: gatsbybot <[email protected]> Co-authored-by: Tyler Barnes <[email protected]>
gatsbyjs · Aug 9, 2021 · 32722f0 · 32722f0
1 parent 22681e7
commit 32722f0
Show file tree

Hide file tree

Showing 2 changed files with 412 additions and 125 deletions.
diff --git a/packages/gatsby-source-wordpress/__tests__/fetch-referenced-media-items.test.js b/packages/gatsby-source-wordpress/__tests__/fetch-referenced-media-items.test.js
@@ -0,0 +1,289 @@
+jest.mock(`../dist/utils/fetch-graphql`, () => jest.fn())
+
+import fetchGraphql from "../dist/utils/fetch-graphql"
+import { fetchMediaItemsBySourceUrl, fetchMediaItemsById } from "../dist/steps/source-nodes/fetch-nodes/fetch-referenced-media-items"
+import { createContentDigest } from "gatsby-core-utils"
+import store from "../dist/store"
+
+const fakeReporter = {
+  panic: msg => {
+    console.error(msg)
+  },
+  info: msg => {
+    console.log(msg)
+  },
+}
+
+const getNodeMock = jest.fn()
+
+
+describe(`fetch-referenced-media-items`, () => {
+  beforeAll(() => {
+    store.dispatch.gatsbyApi.setState({
+      pluginOptions: {
+        schema: {
+          perPage: 2,
+        },
+      },
+    })
+  })
+
+  afterEach(() => {
+    jest.resetAllMocks()
+  })
+
+  describe(`fetchMediaItemsBySourceUrl`, () => {
+
+const createApi = () => {
+  return {
+    actions: {
+      createTypes: jest.fn(),
+      createNode: jest.fn(),
+      deleteNode: jest.fn(),
+    },
+    reporter: fakeReporter,
+    createNodeId: jest.fn(),
+    async getNode(id) {
+      return {
+        localFile: {
+          id: id,
+        },
+      }
+    },
+  }
+}
+
+    it(`should properly download multiple pages`, async () => {
+      fetchGraphql
+        .mockResolvedValueOnce({
+          data: {
+            mediaItem__index_0: null,
+            mediaItem__index_1: null,
+          },
+        })
+        .mockResolvedValueOnce({
+          data: {
+            mediaItem__index_2: {
+              id: 2,
+              mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+            },
+            mediaItem__index_3: {
+              id: 3,
+              mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+            },
+          },
+        })
+        .mockResolvedValueOnce({
+          data: {
+            mediaItem__index_4: null,
+            mediaItem__index_5: null,
+          },
+        })
+        .mockResolvedValueOnce({
+          data: {
+            mediaItem__index_6: null,
+            mediaItem__index_7: null,
+          },
+        })
+      const result = await fetchMediaItemsBySourceUrl({
+        mediaItemUrls: [
+          `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3?_=7`,
+          `https://wordpress.host/wp-content/uploads/2018/05/file2.mp3?_=7`,
+          `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+          `https://wordpress.host/wp-content/uploads/2018/05/file2.mp3`,
+        ],
+        createContentDigest,
+        helpers: createApi(),
+      })
+      expect(result).toHaveLength(2)
+    })
+
+
+    it(`should properly download a single page if there is only 1`, async () => {
+      store.dispatch.gatsbyApi.setState({
+        pluginOptions: {
+          schema: {
+            perPage: 5,
+          },
+        },
+      })
+
+      fetchGraphql
+        .mockResolvedValueOnce({
+          data: {
+            mediaItem__index_0: {
+              id: 0,
+              mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+            },
+            mediaItem__index_1: {
+              id: 1,
+              mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+            },
+          },
+        })
+
+      const result = await fetchMediaItemsBySourceUrl({
+        mediaItemUrls: [
+          `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+          `https://wordpress.host/wp-content/uploads/2018/05/file2.mp3`,
+        ],
+        selectionSet: `id\nmediaItemUrl`,
+        createContentDigest,
+        helpers: createApi(),
+      })
+      expect(result).toHaveLength(2)
+    })
+  })
+
+
+  describe(`fetchMediaItemsById`, () => {
+
+    const createApi = () => {
+      return {
+        actions: {
+          createTypes: jest.fn(),
+          createNode: jest.fn(),
+          deleteNode: jest.fn(),
+        },
+        reporter: fakeReporter,
+        createNodeId: jest.fn(),
+        getNode: getNodeMock
+      }
+    }
+
+    it(`should properly download multiple pages of ids`, async () => {
+      getNodeMock
+      .mockReturnValueOnce(undefined)
+      .mockReturnValueOnce(undefined)
+      .mockReturnValueOnce(undefined)
+      .mockReturnValueOnce(undefined)
+      .mockReturnValueOnce({
+        localFile: {
+          id: 0,
+        }})
+        .mockReturnValueOnce({
+          localFile: {
+            id: 1,
+          }})
+          .mockReturnValueOnce({
+            localFile: {
+              id: 2,
+            }})
+            .mockReturnValueOnce({
+              localFile: {
+                id: 3,
+              }})
+      store.dispatch.gatsbyApi.setState({
+        pluginOptions: {
+          schema: {
+            perPage: 2,
+          },
+        },
+      })
+
+
+      fetchGraphql
+        .mockResolvedValueOnce({
+          data: {
+            mediaItems: {
+              nodes: [{
+                id: 0,
+                mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+              },{
+                id: 1,
+                mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+              },]
+            }
+          },
+        })
+        .mockResolvedValueOnce({
+          data: {
+            mediaItems: {
+              nodes: [{
+                id: 2,
+                mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file2.mp3`,
+              },{
+                id: 3,
+                mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file3.mp3`,
+              },]
+            }
+          },
+        })
+      const result = await fetchMediaItemsById({
+        mediaItemIds: [
+          btoa(`attachment:1`),
+          btoa(`attachment:2`),
+          btoa(`attachment:3`),
+          btoa(`attachment:4`),
+        ],
+        settings: {
+          limit: 5
+        },
+        typeInfo: {
+          pluralName: `mediaItems`,
+          nodesTypeName: `MediaItem`
+        },
+
+        createContentDigest,
+        helpers: createApi(),
+      })
+      expect(result).toHaveLength(4)
+    })
+
+
+    xit(`should properly download a single page of ids if there is only 1`, async () => {
+      getNodeMock
+      .mockReturnValueOnce(undefined)
+      .mockReturnValueOnce(undefined)
+      .mockReturnValueOnce({
+        localFile: {
+          id: 0,
+        }})
+        .mockReturnValueOnce({
+          localFile: {
+            id: 1,
+          }})
+
+      store.dispatch.gatsbyApi.setState({
+        pluginOptions: {
+          schema: {
+            perPage: 5,
+          },
+        },
+      })
+
+      fetchGraphql
+        .mockResolvedValueOnce({
+          data: {
+            mediaItems: {
+              nodes: [{
+                id: 0,
+                mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+              },{
+                id: 1,
+                mediaItemUrl: `https://wordpress.host/wp-content/uploads/2018/05/file1.mp3`,
+              },]
+            }
+          },
+        })
+
+      const result = await fetchMediaItemsById({
+        mediaItemIds: [
+          btoa(`attachment:1`), btoa(`attachment:2`)
+        ],
+        settings: {
+          limit: 5
+        },
+        typeInfo: {
+          pluralName: `mediaItems`,
+          nodesTypeName: `MediaItem`
+        },
+
+        selectionSet: `id\nmediaItemUrl`,
+        createContentDigest,
+        helpers: createApi(),
+      })
+      expect(result).toHaveLength(2)
+    })
+  })
+})