Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(wordpress): ensure all file links are rewritten #32679

Merged

Conversation

rburgst
Copy link
Contributor

@rburgst rburgst commented Aug 3, 2021

  • in the case of either having a small schema.perPage setting
    or many many referenced resources on a single page only the first
    page of links were properly rewritten
  • now we ensure that all pages are fully processed until we resolve the
    promise
  • this is a recommit of fix(wordpress): ensure all file links are rewritten #31652

fixes #31646

Description

Documentation

Related Issues

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label Aug 3, 2021
- in the case of either having a small `schema.perPage` setting
  or many many referenced resources on a single page only the first
  page of links were properly rewritten
- now we ensure that all pages are fully processed until we resolve the
  promise
- this is an improved recommit of gatsbyjs#31652

fixes gatsbyjs#31646
@rburgst rburgst force-pushed the bugfix/wordpress-file-rewrite-fix branch from 452f423 to bc98ba4 Compare August 3, 2021 18:36
@TylerBarnes TylerBarnes added topic: source-wordpress Related to Gatsby's integration with WordPress and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels Aug 3, 2021
@TylerBarnes TylerBarnes self-requested a review August 3, 2021 22:22
Copy link
Contributor

@TylerBarnes TylerBarnes left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks so much for working on and fixing this! This is a really important change that will help a lot of folks! 🎉
And apologies for the delay on getting this reviewed/merged, things have been super busy

@TylerBarnes TylerBarnes merged commit 32722f0 into gatsbyjs:master Aug 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: source-wordpress Related to Gatsby's integration with WordPress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[gatsby-source-wordpress] fetchReferencedMediaItemsAndCreateNodes resolves too early
2 participants