fix(gatsby-cli): added HOST environment variable #26712
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
gatsbot
bot
added
the
status: triage needed
sidharthachatterjee
added
topic: cli
wardpeet
changed the title
wardpeet
reviewed
Sep 29, 2020
LekoArts
added
the
status: awaiting author response
|
Hi @mgurevin, is this still something you can work on? |
|
I'm not sure passing the port to serve as well is a good idea, as you'd expect them to be on different ports. The host could be passed though. |
ascorbic
approved these changes
Apr 16, 2021
ascorbic
added
the
bot: merge on green
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
I wanted to run develop command with a custom listener address under the container environment but I couldn't find a way to comply 12factor. So this patch considers
HOSTenv value as the default host value if defined.Documentation
Related Issues