Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(gatsby-cli): Switch host env to GATSBY_ prefix #31426

Merged
merged 1 commit into from
May 17, 2021

Conversation

ascorbic
Copy link
Contributor

Hello Gatsbytes!
The recent PR #26712 that I merged added support for using HOST to set the host to listen for develop. Unfortunately, the HOST var is often populated by default, and in those cases the develop server doesn't listen on localhost, but just on the value of the var. This PR switches it to use an env var that is Gatsby-specific, so that it doesn't happen by mistake.

@gatsbot gatsbot bot added the status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer label May 14, 2021
@LekoArts LekoArts added topic: cli Related to the Gatsby CLI and removed status: triage needed Issue or pull request that need to be triaged and assigned to a reviewer labels May 17, 2021
Copy link
Contributor

@LekoArts LekoArts left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@LekoArts LekoArts merged commit 7c587bf into gatsbyjs:master May 17, 2021
@ascorbic ascorbic deleted the fix/dev-host branch May 17, 2021 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
topic: cli Related to the Gatsby CLI
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants