Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ruby/Python bindings packaging #6

Merged
merged 13 commits into from
Sep 15, 2021
Merged

Ruby/Python bindings packaging #6

merged 13 commits into from
Sep 15, 2021

Conversation

j-rivero
Copy link
Contributor

@j-rivero j-rivero commented Sep 3, 2021

A bit of jazz in the PR for different things:

  • Remove Sid: we already update ign-math6 in Debian unstable (aka Sid) and the become ready for users. Not need to build our owns.
  • Add support for ruby bindings: build-dep need ruby-dev and the new ruby-ignition-math6 package is ready
  • Add support for python bindings: python helper via dh_python and the new package python3-ignition-math6
  • Added long description to math6 packages

Tested here: https://build.osrfoundation.org/job/ign-math6-debbuilder/1029/

@chapulina chapulina self-requested a review September 3, 2021 23:43
Copy link
Contributor

@chapulina chapulina left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Python packages LGTM, but we need to set PYTHONPATH=/usr/lib/x86_64-linux-gnu/python before using, I don't know if that's standard.

I haven't checked the Ruby packages, but I can try next week.

@chapulina
Copy link
Contributor

Python packages are working for me without setting new env vars as of the latest nightly 🎉

For Ruby, I still need to set an env var manually:

$ RUBYLIB=/usr/lib/x86_64-linux-gnu/ruby/ irb
irb(main):001:0> require 'ignition/math'
=> true

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants