Skip to content
This repository has been archived by the owner on Dec 29, 2021. It is now read-only.

Add Bullet #3

Merged
merged 3 commits into from
Jun 18, 2021
Merged

Add Bullet #3

merged 3 commits into from
Jun 18, 2021

Conversation

chapulina
Copy link
Contributor

Bullet support was added in gazebosim/gz-physics#208, see gazebosim/gz-physics#44

Signed-off-by: Louise Poubel <[email protected]>
@j-rivero
Copy link
Contributor

A couple of things I think are missing:

  • bullet inside the build deps 555844a
  • install files are needed to indicate the packaging which files go into the new packages 60ffbf3

Copy link
Contributor

@j-rivero j-rivero left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we might need a prerelease to check that bullet is well packaged, we are to good to test IMHO

@chapulina
Copy link
Contributor Author

bullet inside the build deps 555844a

I didn't do this originally on purpose, so current users of ignition-physics3 don't get a new dependency without opting-in. Is there a way to accomplish this?

Install files are needed to indicate the packaging which files go into the new packages 60ffbf3

Ahh thanks, I had done all that, but I didn't add the files 🤦‍♀️

@j-rivero
Copy link
Contributor

bullet inside the build deps 555844a

I didn't do this originally on purpose, so current users of ignition-physics3 don't get a new dependency without opting-in. Is there a way to accomplish this?

build-deps (the ones at the top of the control) are only being used when building, in our case in the Jenkins jobs. Should not affect final users.

@chapulina
Copy link
Contributor Author

Gotcha, thanks for the clarification 👍

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants