Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

👩‍🌾 Remove reliance on bitbucket pipelines files #501

Merged
merged 5 commits into from
Aug 26, 2021

Conversation

chapulina
Copy link
Contributor

@chapulina chapulina commented Aug 23, 2021

Closes #203

We used that file to determine the test platform for each version of each library. However:

  • Since migrating to GitHub we haven't really been paying attention to that file
  • All files are currently pointing to Bionic and there are none pointing to Focal. But Bionic is the fallback anyway in case that file doesn't exist.

So removing the support for that file, as well as the files themselves, should have no impact on our CI.

I suggest we do that to avoid further confusion, we often get questions about this file.

Whenever we need to target different platforms for each branch, we should open an issue for it and tackle it in a different way.

See this PR that removes the file and CI still passes: gazebosim/gz-fuel-tools#196

Tests with ign-math:


https://github.com/osrf/buildfarmer/issues/224

@scpeters
Copy link
Contributor

I think the most impacted branches for this change would be the gazebo9 dependencies. I'd like to see pull requests removing the bitbucket-pipelines.yml files from ign-cmake0, ign-math4, ign-common1, and sdf6 branches before merging this

@scpeters
Copy link
Contributor

scpeters commented Aug 23, 2021

I think the most impacted branches for this change would be the gazebo9 dependencies. I'd like to see pull requests removing the bitbucket-pipelines.yml files from ign-cmake0, ign-math4, ign-common1, and sdf6 branches before merging this

Sorry, something went wrong.

@chapulina
Copy link
Contributor Author

I think the most impacted branches for this change would be the gazebo9 dependencies

Nice catch! I didn't think of Xenial. I'll see what I can do

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@j-rivero
Copy link
Contributor

Nice catch! I didn't think of Xenial. I'll see what I can do

Xenial is EOL, we should not need to maintain anything on it anymore.

@chapulina
Copy link
Contributor Author

Xenial is EOL

All our branches that relied on Xenial should have PRs open already, listed above 👍

@j-rivero
Copy link
Contributor

All our branches that relied on Xenial should have PRs open already, listed above +1

ouk sorry, I should learn first :)

@j-rivero
Copy link
Contributor

I still see some code in gazebo.dsl using the file there. We can probably archive https://github.com/osrf/bash-yaml as soon as this is merged.

Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Copy link
Contributor Author

I still see some code in gazebo.dsl using the file there.

Ok, going all in!

@chapulina chapulina merged commit 3f7649b into master Aug 26, 2021
@chapulina chapulina deleted the chapulina/bitbucket_pipelines branch August 26, 2021 20:41
@chapulina
Copy link
Contributor Author

https://github.com/osrf/bash-yaml/ archived 📁

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Dependency on bitbucket-pipelines.yml should be removed
3 participants