-
Notifications
You must be signed in to change notification settings - Fork 9
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
👩🌾 Remove reliance on bitbucket pipelines files #501
Conversation
Signed-off-by: Louise Poubel <[email protected]>
I think the most impacted branches for this change would be the gazebo9 dependencies. I'd like to see pull requests removing the |
|
Nice catch! I didn't think of Xenial. I'll see what I can do |
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Xenial is EOL, we should not need to maintain anything on it anymore. |
All our branches that relied on Xenial should have PRs open already, listed above 👍 |
ouk sorry, I should learn first :) |
I still see some code in |
Signed-off-by: Louise Poubel <[email protected]>
Ok, going all in!
|
https://github.com/osrf/bash-yaml/ archived 📁 |
Closes #203
We used that file to determine the test platform for each version of each library. However:
So removing the support for that file, as well as the files themselves, should have no impact on our CI.
I suggest we do that to avoid further confusion, we often get questions about this file.
Whenever we need to target different platforms for each branch, we should open an issue for it and tackle it in a different way.
See this PR that removes the file and CI still passes: gazebosim/gz-fuel-tools#196
Tests with
ign-math
:ign-math6
branch (hasbitbucket-pipelines
)bitbucket-pipelines
)https://github.com/osrf/buildfarmer/issues/224