Remove fuel.ignitionrobotics.org from ClientConfig

[nkoenig]

Signed-off-by: Nate Koenig [email protected]

🎉 New feature

Summary

Removes fuel.ignitionrobotics.org from ClientConfig. This will leave fuel.gazebosim.org.

Test it

Run the tests.

Checklist

• Signed all commits for DCO
• Added tests
• Added example and/or tutorial
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #293 (7df811b) into gz-fuel-tools8 (7b6ce8a) will increase coverage by 0.79%.
The diff coverage is n/a.

@@                Coverage Diff                 @@
##           gz-fuel-tools8     #293      +/-   ##
==================================================
+ Coverage           73.77%   74.56%   +0.79%     
==================================================
  Files                  20       20              
  Lines                2871     2866       -5     
==================================================
+ Hits                 2118     2137      +19     
+ Misses                753      729      -24     

Impacted Files	Coverage Δ
src/ClientConfig.cc	81.70% <ø> (-0.39%)	⬇️
src/RestClient.cc	67.42% <0.00%> (-4.55%)	⬇️
src/gz.cc	48.88% <0.00%> (+7.44%)	⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[chapulina]

Will this make it impossible to load models that refer to fuel.ignitionrobotics? We may want to do a softer tick-tock on this one, just because of the number of assets that are available everywhere. Fuel-Tools 9 will most likely be on Gazebo-H (because gz-msgs will most certainly be bumped), and that may be too soon to pull the plug?

[nkoenig]

Will this make it impossible to load models that refer to fuel.ignitionrobotics? We may want to do a softer tick-tock on this one, just because of the number of assets that are available everywhere. Fuel-Tools 9 will most likely be on Gazebo-H (because gz-msgs will most certainly be bumped), and that may be too soon to pull the plug?

I think this is what you're looking for: #294

[ahcorde]

are windows failures expected https://build.osrfoundation.org/job/ign_fuel-tools-pr-win/294/ ?

[nkoenig]

are windows failures expected https://build.osrfoundation.org/job/ign_fuel-tools-pr-win/294/ ?

Yes, the windows tests are not passing. These tests failures are expected.

[scpeters]

this was merged to gz-fuel-tools8 but bumped the major version to 9. was it supposed to go to main?