-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adds a deprecation warning about fuel.ignitionrobotics.org #294
Conversation
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-fuel-tools4 #294 +/- ##
===================================================
+ Coverage 76.21% 76.76% +0.55%
===================================================
Files 19 19
Lines 2724 2737 +13
===================================================
+ Hits 2076 2101 +25
+ Misses 648 636 -12
Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here. |
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Models that contain |
src/FuelClient.cc
Outdated
/// \brief Checks the provided URI for fuel.ignitionrobotics.org, and | ||
/// prints a deprecation warning message if found. | ||
/// \param[in] _uri URI to check | ||
/// DEPRECATED/DEPRECATION: remove this function in Gazebo H. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure removing this for Gazebo H is a good idea. There might still be worlds/models that use fuel.ignitionrobotics.org
on Fuel well past Gazebo H.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Signed-off-by: Nate Koenig <[email protected]>
Looks like most of the changes in this PR were included in #304. |
Closing as a duplicate of #304 |
🎉 New feature
Summary
Outputs a deprecation warning about
fuel.ignitionrobotics.org
when encountered. This will help people transition tofuel.gazebosim.org
.Don't merge this until @nkoenig has updated the models and worlds owned by openrobotics on Fuel, and posted a guide on how others can change their models and worlds.
Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.