Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adds a deprecation warning about fuel.ignitionrobotics.org #294

Closed
wants to merge 8 commits into from

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Aug 18, 2022

🎉 New feature

Summary

Outputs a deprecation warning about fuel.ignitionrobotics.org when encountered. This will help people transition to fuel.gazebosim.org.

Don't merge this until @nkoenig has updated the models and worlds owned by openrobotics on Fuel, and posted a guide on how others can change their models and worlds.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Nate Koenig added 2 commits August 18, 2022 14:48
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Aug 18, 2022
@codecov
Copy link

codecov bot commented Aug 18, 2022

Codecov Report

Merging #294 (1d35013) into ign-fuel-tools4 (40d8bb7) will increase coverage by 0.55%.
The diff coverage is 92.30%.

❗ Current head 1d35013 differs from pull request most recent head 765bf6c. Consider uploading reports for the commit 765bf6c to get more accurate results

@@                 Coverage Diff                 @@
##           ign-fuel-tools4     #294      +/-   ##
===================================================
+ Coverage            76.21%   76.76%   +0.55%     
===================================================
  Files                   19       19              
  Lines                 2724     2737      +13     
===================================================
+ Hits                  2076     2101      +25     
+ Misses                 648      636      -12     
Impacted Files Coverage Δ
src/FuelClient.cc 73.58% <92.30%> (+0.82%) ⬆️
src/gz.cc 46.56% <0.00%> (+2.38%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@chapulina chapulina added the ign to gz Renaming Ignition to Gazebo. label Aug 26, 2022
Migration.md Outdated Show resolved Hide resolved
src/FuelClient.cc Show resolved Hide resolved
Nate Koenig and others added 4 commits October 5, 2022 05:30
@azeey
Copy link
Contributor

azeey commented Oct 17, 2022

Models that contain fuel.ignitionrobotics.org are broken as of #293 for people that build from source. Any way we expedite this?

/// \brief Checks the provided URI for fuel.ignitionrobotics.org, and
/// prints a deprecation warning message if found.
/// \param[in] _uri URI to check
/// DEPRECATED/DEPRECATION: remove this function in Gazebo H.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure removing this for Gazebo H is a good idea. There might still be worlds/models that use fuel.ignitionrobotics.org on Fuel well past Gazebo H.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

src/FuelClient.cc Outdated Show resolved Hide resolved
@azeey
Copy link
Contributor

azeey commented Jan 13, 2023

Looks like most of the changes in this PR were included in #304.

@azeey
Copy link
Contributor

azeey commented Mar 13, 2023

Closing as a duplicate of #304

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel ign to gz Renaming Ignition to Gazebo.
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants