Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable failing tests #76

Merged
merged 10 commits into from
Aug 7, 2020
Merged

Disable failing tests #76

merged 10 commits into from
Aug 7, 2020

Conversation

chapulina
Copy link
Contributor

Having constant unstable CI makes it harder to notice when new test failures are introduced. The goal is to have green CI across the board and keep it that way.

This PR is just disabling known test failures, which have been listed on #75 . We should go back and fix these asap instead of just leaving them there forever.

@chapulina chapulina self-assigned this Jun 10, 2020
@github-actions github-actions bot added the 📜 blueprint Ignition Blueprint label Jun 10, 2020
@codecov
Copy link

codecov bot commented Jun 10, 2020

Codecov Report

Merging #76 into ign-gui2 will decrease coverage by 45.62%.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-gui2      #76       +/-   ##
=============================================
- Coverage     60.18%   14.55%   -45.63%     
=============================================
  Files            16       13        -3     
  Lines          2082     1333      -749     
=============================================
- Hits           1253      194     -1059     
- Misses          829     1139      +310     
Impacted Files Coverage Δ
include/ignition/gui/Plugin.hh 0.00% <0.00%> (-100.00%) ⬇️
include/ignition/gui/Helpers.hh 0.00% <0.00%> (-100.00%) ⬇️
src/MainWindow.cc 0.00% <0.00%> (-96.89%) ⬇️
src/plugins/world_stats/WorldStats.cc 1.12% <0.00%> (-95.51%) ⬇️
src/Application.cc 1.36% <0.00%> (-83.34%) ⬇️
src/plugins/world_control/WorldControl.cc 1.16% <0.00%> (-77.91%) ⬇️
src/Dialog.cc 0.00% <0.00%> (-68.43%) ⬇️
src/Plugin.cc 0.00% <0.00%> (-60.28%) ⬇️
src/ign.cc 0.00% <0.00%> (-37.84%) ⬇️
src/plugins/topic_echo/TopicEcho.cc
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 9b38679...28dcb66. Read the comment docs.

#else
// TODO(anyone) Use createTextureFromNativeObject
this->texture = this->window->createTextureFromId(
newId, sz, QQuickWindow::TextureIsOpaque);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@iche033, homebrew is already using Qt 5.14 and there's a new deprecation warning:

'createTextureFromId' is deprecated: Use createTextureFromNativeObject() instead

See Obsolete Members for QQuickWindow and QQuickWindow::createTextureFromNativeObject. Do you think that fixing this warning will be quick or does it need more thought? I didn't dig too deep to find out how to get the nativeObjectPtr.

@chapulina chapulina requested a review from j-rivero June 15, 2020 18:42
@j-rivero
Copy link
Contributor

I've implemented a couple of helper functions in chapuilna/failing_tests_jrivero

@chapulina
Copy link
Contributor Author

Thanks, Jose, those look great! Feel free to push to this branch!

@chapulina chapulina force-pushed the chapuilna/failing_tests branch from a212ba5 to 9af3ed6 Compare July 1, 2020 00:41
@chapulina
Copy link
Contributor Author

Thanks for the fix, @j-rivero ! Your commit didn't have DCO, so I squashed them all to add DCO and you disappeared as an author 😕 Sorry 😢

@chapulina chapulina mentioned this pull request Jul 1, 2020
@chapulina
Copy link
Contributor Author

@j-rivero , we're having some compilation problems on Windows:

D:\Jenkins\workspace\ign_gui-pr-win\ws\ign-gui\src\MainWindow_TEST.cc(50,1): error C2011: 'MainWindowTest_DISABLED_Testname_Test': 'class' type redefinition [D:\Jenkins\workspace\ign_gui-pr-win\ws\build\ignition-gui2\src\UNIT_MainWindow_TEST.vcxproj]

I tried something on e683701 but I think we may need some # operators 🤔

@j-rivero
Copy link
Contributor

j-rivero commented Jul 9, 2020

I've changed this PR to use gazebosim/gz-cmake#102 that provides the filter macros we were using here before.
Tested in: Build Status

chapulina and others added 6 commits July 20, 2020 19:55
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
@j-rivero j-rivero force-pushed the chapuilna/failing_tests branch from 12699c7 to 59e8376 Compare July 20, 2020 17:55
@j-rivero
Copy link
Contributor

j-rivero commented Aug 7, 2020

This run on Windows check these changes together with ign-cmake2 support: Build Status Seems to do what it is expected to do, no test failures.

@j-rivero j-rivero merged commit 6b48577 into ign-gui2 Aug 7, 2020
@j-rivero j-rivero deleted the chapuilna/failing_tests branch August 7, 2020 18:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants