-
Notifications
You must be signed in to change notification settings - Fork 44
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable failing tests #76
Conversation
Codecov Report
@@ Coverage Diff @@
## ign-gui2 #76 +/- ##
=============================================
- Coverage 60.18% 14.55% -45.63%
=============================================
Files 16 13 -3
Lines 2082 1333 -749
=============================================
- Hits 1253 194 -1059
- Misses 829 1139 +310
Continue to review full report at Codecov.
|
src/plugins/Scene3D.cc
Outdated
#else | ||
// TODO(anyone) Use createTextureFromNativeObject | ||
this->texture = this->window->createTextureFromId( | ||
newId, sz, QQuickWindow::TextureIsOpaque); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@iche033, homebrew is already using Qt 5.14 and there's a new deprecation warning:
'createTextureFromId' is deprecated: Use createTextureFromNativeObject() instead
See Obsolete Members for QQuickWindow and QQuickWindow::createTextureFromNativeObject. Do you think that fixing this warning will be quick or does it need more thought? I didn't dig too deep to find out how to get the nativeObjectPtr
.
I've implemented a couple of helper functions in |
Thanks, Jose, those look great! Feel free to push to this branch! |
a212ba5
to
9af3ed6
Compare
Thanks for the fix, @j-rivero ! Your commit didn't have DCO, so I squashed them all to add DCO and you disappeared as an author 😕 Sorry 😢 |
@j-rivero , we're having some compilation problems on Windows:
I tried something on e683701 but I think we may need some |
I've changed this PR to use gazebosim/gz-cmake#102 that provides the filter macros we were using here before. |
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Louise Poubel <[email protected]> Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
Signed-off-by: Jose Luis Rivero <[email protected]>
12699c7
to
59e8376
Compare
Having constant unstable CI makes it harder to notice when new test failures are introduced. The goal is to have green CI across the board and keep it that way.
This PR is just disabling known test failures, which have been listed on #75 . We should go back and fix these asap instead of just leaving them there forever.