Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. Weโ€™ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

๐Ÿ‘ฉโ€๐ŸŒพ Export ignition-cmakeN_INCLUDE_DIRS #109

Closed
wants to merge 1 commit into from

Conversation

chapulina
Copy link
Contributor

While trying to use the macros from #102 on ign-rendering, that library was not being able to find the include ignition/utilities/ExtraTestMacros.hh.

Strangely, ign-gazebo and ign-gui are able to find it fine, see gazebosim/gz-sim#209 and gazebosim/gz-gui#76.

After digging through the CMake variables, I suspect ign-gazebo and ign-gui may be getting the correct include directory from another dependency. My initial guess was ign-tools, because that's a top-level include (IGNITION-TOOLS_INCLUDE_DIRS=/home/chapulina/blueprint_ws/install/include) as opposed to a library-specific include path.

In any case, this PR exposes the standard _INCLUDE_DIRS variable for ign-cmake so it can be used by other projects.

@chapulina chapulina requested a review from mxgrey as a code owner August 18, 2020 23:38
@github-actions github-actions bot added ๐Ÿฐ citadel Ignition Citadel ๐Ÿ“œ blueprint Ignition Blueprint ๐Ÿ”ฎ dome Ignition Dome labels Aug 18, 2020
@mxgrey
Copy link
Contributor

mxgrey commented Aug 19, 2020

Could you point me at the CMakeLists.txt for ign-rendering that links to the ignition-cmake#::utilities target? This sounds like an issue that should be solved in the downstream cmake project, not in this project.

@scpeters
Copy link
Member

I suspect ign-gazebo and ign-gui may be getting the correct include directory from another dependency.

Could you point me at the CMakeLists.txt for ign-rendering that links to the ignition-cmake#::utilities target? This sounds like an issue that should be solved in the downstream cmake project, not in this project.

I think ign-gazebo and ign-gui are getting the ignition-cmake#::utilities target from ignition-plugin, which links to it publicly in the core and loader components:

So I agree with @mxgrey that the problem is likely that ign-rendering is not properly linking to ignition-cmake#::utilities when it should be, and we shouldn't need to merge this.

Copy link
Member

@scpeters scpeters left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this is a problem in downstream libraries, not in ign-cmake (see earlier comments)

@chapulina
Copy link
Contributor Author

Ah thank you both. I was just using include_directories on ign-rendering with the new variable:

gazebosim/gz-rendering@ign-rendering2...chapulina/disable_failing

Nice detective work, @scpeters. I searched for an example throughout the libraries and forgot to check ign-plugin. That's what I need!

@chapulina chapulina closed this Aug 19, 2020
@chapulina chapulina deleted the chapulina/include_dirs branch August 19, 2020 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
๐Ÿ“œ blueprint Ignition Blueprint ๐Ÿฐ citadel Ignition Citadel ๐Ÿ”ฎ dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants