Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

⬆️ 6.5.0 #155

Merged
merged 2 commits into from
Sep 5, 2020
Merged

⬆️ 6.5.0 #155

merged 2 commits into from
Sep 5, 2020

Conversation

chapulina
Copy link
Contributor

Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from scpeters September 4, 2020 20:51
@github-actions github-actions bot added 🏰 citadel Ignition Citadel 📜 blueprint Ignition Blueprint 🔮 dome Ignition Dome labels Sep 4, 2020
@codecov
Copy link

codecov bot commented Sep 4, 2020

Codecov Report

Merging #155 into ign-math6 will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           ign-math6     #155   +/-   ##
==========================================
  Coverage      99.23%   99.23%           
==========================================
  Files             59       59           
  Lines           5867     5867           
==========================================
  Hits            5822     5822           
  Misses            45       45           
Impacted Files Coverage Δ
include/ignition/math/Helpers.hh 98.75% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 87d3406...d5e012c. Read the comment docs.

@scpeters
Copy link
Member

scpeters commented Sep 4, 2020

I'm seeing 2 windows warnings in sdformat when compiling ign-math6 from source:

the warnings look related to #152, not sure why they didn't show up there

Signed-off-by: Louise Poubel <[email protected]>
@scpeters
Copy link
Member

scpeters commented Sep 5, 2020

looks like the windows warnings are fixed: Build Status https://build.osrfoundation.org/job/sdformat-ci-pr_any-windows7-amd64/1533/badge

@chapulina chapulina merged commit bf1e3e2 into ign-math6 Sep 5, 2020
@chapulina chapulina deleted the chapulina/6.5.0 branch September 5, 2020 03:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
📜 blueprint Ignition Blueprint 🏰 citadel Ignition Citadel 🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants