-
Notifications
You must be signed in to change notification settings - Fork 5
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
MJCF to SDF: Add Material #42
Conversation
Signed-off-by: ahcorde <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #42 +/- ##
==========================================
- Coverage 97.54% 97.20% -0.34%
==========================================
Files 18 19 +1
Lines 773 824 +51
==========================================
+ Hits 754 801 +47
- Misses 19 23 +4
Continue to review full report at Codecov.
|
Signed-off-by: ahcorde <[email protected]>
I have created an issue about the difference in texture mapping between Gazebo and Mujoco for primitive shapes (#58). I want to test how it works with meshes as well, but we don't have mesh conversion yet. I think it's safe to say SDFormat doesn't support |
material.set_diffuse(su.rgba_to_color(geom.rgba)) | ||
material.set_ambient(su.rgba_to_color(geom.rgba)) | ||
material.set_specular(su.rgba_to_color(geom.rgba)) | ||
material.set_emissive(su.rgba_to_color(geom.rgba)) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we should be setting the emissive property based on the rgba
, but I don't have a good suggestion. Maybe we can come back to it later.
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: ahcorde [email protected]
🎉 New feature
Summary
Add Material
I have two issues:
file.png
and we got from the python APIfile-hash.png
, should I create this file ? add a flag to export them ?gridsize="1 1"
. There is other way to define textures, please review this fieldgridlayout: string, “…………”
and share your thoughts. This way is not defined ignition, this may require some work in other ignition librariesChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.