Fix CONFIG arg in ign_find_package(DART) call #119
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The
CONFIG
argument tofind_package
does not have a corresponding argument inign_find_package
, though it happens to work in ourign_find_package(DART)
call by accident since it gets treated as a component. It can be properly passed through as anEXTRA_ARGS
parameter.To reproduce the bug, change the order of the
ign_find_package
parameters with the following patch and observe that it gives a cmake warning for unrecognized arguments:I've filed gazebosim/gz-cmake#114 to track adding
CONFIG
as a supported option toign_find_package
, but let's just fix it for now.