Backport #119 to ign-physics2: Fix CONFIG arg in ign_find_package(DART) call #121
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The CONFIG argument to find_package does not have a corresponding argument in ign_find_package, though it happens to work in our ign_find_package(DART) call by accident since it gets treated as a component. It can be properly passed through as an EXTRA_ARGS parameter. Signed-off-by: Steve Peters <[email protected]>
mxgrey
approved these changes
Oct 8, 2020
8 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #119 to ign-physics2. Use rebase and merge.
Original description:
Fix CONFIG arg in ign_find_package(DART) call (#119)
The CONFIG argument to find_package does not have a corresponding
argument in ign_find_package, though it happens to work in our
ign_find_package(DART) call by accident since it gets treated
as a component. It can be properly passed through as an
EXTRA_ARGS parameter.
Signed-off-by: Steve Peters [email protected]