Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added joint_features common tests #408

Merged
merged 6 commits into from
Sep 2, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Sep 1, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Related to #372

Summary

Added joint_features common tests

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde requested a review from mjcarroll September 1, 2022 09:37
@ahcorde ahcorde self-assigned this Sep 1, 2022
Signed-off-by: ahcorde <[email protected]>
Base automatically changed from ahcorde/improved_common_test/simulation_features to gz-physics6 September 1, 2022 21:58
@codecov
Copy link

codecov bot commented Sep 1, 2022

Codecov Report

Merging #408 (5a75b29) into gz-physics6 (99a8c8e) will decrease coverage by 0.59%.
The diff coverage is 0.00%.

@@               Coverage Diff               @@
##           gz-physics6     #408      +/-   ##
===============================================
- Coverage        74.44%   73.85%   -0.60%     
===============================================
  Files              128      128              
  Lines             5737     5775      +38     
===============================================
- Hits              4271     4265       -6     
- Misses            1466     1510      +44     
Impacted Files Coverage Δ
bullet/src/JointFeatures.cc 0.00% <0.00%> (ø)
bullet/src/SimulationFeatures.cc 0.00% <0.00%> (ø)
include/gz/physics/detail/Joint.hh 76.11% <0.00%> (-23.89%) ⬇️
dartsim/src/EntityManagementFeatures.cc 82.78% <0.00%> (-1.00%) ⬇️
include/gz/physics/detail/GetEntities.hh 100.00% <0.00%> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde merged commit 78cc33b into gz-physics6 Sep 2, 2022
@ahcorde ahcorde deleted the ahcorde/improved_common_test/joint_features branch September 2, 2022 15:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants