Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

🎈 6.1.0 #441

Merged
merged 4 commits into from
Oct 27, 2022
Merged

🎈 6.1.0 #441

merged 4 commits into from
Oct 27, 2022

Conversation

mjcarroll
Copy link
Contributor

@mjcarroll mjcarroll commented Oct 17, 2022

🎈 Release

Preparation for 6.1.0 release.

Comparison to 6.0.0: gz-physics6_6.0.0...gz-physics6

Needed by gazebosim/gz-sim#1560

Checklist

  • Asked team if this is a good time for a release
  • There are no changes to be ported from the previous major version
  • No PRs targeted at this major version are close to getting in
  • Bumped minor for new features, patch for bug fixes
  • Updated changelog
  • Updated migration guide (as needed)
  • Link to PR updating dependency versions in appropriate repository in gazebo-release (as needed):

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

Signed-off-by: Michael Carroll <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 17, 2022
@codecov
Copy link

codecov bot commented Oct 17, 2022

Codecov Report

Merging #441 (d85b839) into gz-physics6 (ff053ae) will not change coverage.
The diff coverage is n/a.

@@             Coverage Diff              @@
##           gz-physics6     #441   +/-   ##
============================================
  Coverage        75.73%   75.73%           
============================================
  Files              140      140           
  Lines             7034     7034           
============================================
  Hits              5327     5327           
  Misses            1707     1707           

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@scpeters
Copy link
Member

I've reviewing why GetCollision was added to sdf/ConstructCollision.hh

@scpeters
Copy link
Member

I've reviewing why GetCollision was added to sdf/ConstructCollision.hh

https://github.com/gazebosim/gz-physics/pull/373/files#r997339782

why was this API added instead of using GetShapeFromLink::GetShape?

@mjcarroll
Copy link
Contributor Author

why was this API added instead of using GetShapeFromLink::GetShape?

Since we were using the DART implementation as a reference, and DART doesn't have that implemented, it likely was an oversight. I believe that there were some additional physics API template gymnastics that weren't possible to resolve, but @ahcorde has a better memory for that.

@ahcorde
Copy link
Contributor

ahcorde commented Oct 18, 2022

why was this API added instead of using GetShapeFromLink::GetShape?

Since we were using the DART implementation as a reference, and DART doesn't have that implemented, it likely was an oversight. I believe that there were some additional physics API template gymnastics that weren't possible to resolve, but @ahcorde has a better memory for that.

Yes, I was not able to recast the pointer in gz-sim. I'm open to suggestions

@mjcarroll mjcarroll marked this pull request as draft October 27, 2022 13:04
mjcarroll added a commit that referenced this pull request Oct 27, 2022
Based on conversation in #441

Signed-off-by: Michael Carroll <[email protected]>
@mjcarroll
Copy link
Contributor Author

Pending #444

@mjcarroll mjcarroll marked this pull request as ready for review October 27, 2022 14:09
Signed-off-by: Michael Carroll <[email protected]>
@scpeters
Copy link
Member

we're going to need to update the debian metadata; I would recommend making a few test debbuilds before doing the actual release

@scpeters
Copy link
Member

we're going to need to update the debian metadata; I would recommend making a few test debbuilds before doing the actual release

actually, it's already been built by the nightly jobs without any complaints:

I believe it's installing both the bullet and bullet-featherstone plugins together in the -bullet* debs, which I think is fine

so I think the release can proceed

@scpeters scpeters merged commit 96425a2 into gz-physics6 Oct 27, 2022
@scpeters scpeters deleted the releases/6.1.0 branch October 27, 2022 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants