Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed GetCollision API it's redundant #444

Merged
merged 1 commit into from
Oct 27, 2022

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 27, 2022

Signed-off-by: ahcorde [email protected]

🎉 New feature

Summary

Removed GetCollision. FYI @scpeters and @mjcarroll

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde ahcorde self-assigned this Oct 27, 2022
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 27, 2022
@mjcarroll mjcarroll mentioned this pull request Oct 27, 2022
7 tasks
@codecov
Copy link

codecov bot commented Oct 27, 2022

Codecov Report

Merging #444 (5d06005) into gz-physics6 (1836a0b) will increase coverage by 0.36%.
The diff coverage is n/a.

@@               Coverage Diff               @@
##           gz-physics6     #444      +/-   ##
===============================================
+ Coverage        75.36%   75.73%   +0.36%     
===============================================
  Files              140      140              
  Lines             7068     7034      -34     
===============================================
  Hits              5327     5327              
+ Misses            1741     1707      -34     
Impacted Files Coverage Δ
bullet-featherstone/src/SDFFeatures.cc 71.85% <ø> (+0.90%) ⬆️
bullet/src/SDFFeatures.cc 52.78% <ø> (+1.75%) ⬆️
dartsim/src/SDFFeatures.cc 62.55% <ø> (+1.08%) ⬆️
sdf/include/gz/physics/sdf/ConstructCollision.hh 100.00% <ø> (ø)
tpe/plugin/src/SDFFeatures.cc 84.66% <ø> (+5.80%) ⬆️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

@ahcorde ahcorde enabled auto-merge (squash) October 27, 2022 13:42
@ahcorde ahcorde merged commit ff053ae into gz-physics6 Oct 27, 2022
@ahcorde ahcorde deleted the ahcorde/6/remove_getCollision branch October 27, 2022 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants