Enable ogre2 heightmap test

[iche033]

Signed-off-by: Ian Chen [email protected]

🦟 Bug fix

Summary

Run Heightmap_test with ogre2 now that it is supported

This unfortunately reduces the overall test coverage % because various ogre1.x code is not run any more.

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #670 (db68fc9) into ign-rendering6 (a8e06ae) will decrease coverage by 1.21%.
The diff coverage is 100.00%.

@@                Coverage Diff                 @@
##           ign-rendering6     #670      +/-   ##
==================================================
- Coverage           54.92%   53.70%   -1.22%     
==================================================
  Files                 202      202              
  Lines               21102    21106       +4     
==================================================
- Hits                11591    11336     -255     
- Misses               9511     9770     +259     

Impacted Files	Coverage Δ
ogre2/src/Ogre2Heightmap.cc	73.13% <100.00%> (+73.13%)	⬆️
ogre/src/OgreGeometry.cc	0.00% <0.00%> (-81.82%)	⬇️
ogre/src/OgreHeightmap.cc	0.00% <0.00%> (-72.69%)	⬇️
ogre/src/OgreNode.cc	15.38% <0.00%> (-29.81%)	⬇️
ogre/src/OgreVisual.cc	5.92% <0.00%> (-17.04%)	⬇️
ogre/src/OgreConversions.cc	7.14% <0.00%> (-7.15%)	⬇️
ogre/src/OgreRenderEngine.cc	68.37% <0.00%> (-5.43%)	⬇️
ogre/src/OgreScene.cc	23.92% <0.00%> (-2.66%)	⬇️
ogre/src/OgreRTShaderSystem.cc	42.43% <0.00%> (-1.11%)	⬇️
ogre/src/OgreMaterial.cc	40.00% <0.00%> (-0.93%)	⬇️
... and 11 more

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update a8e06ae...db68fc9. Read the comment docs.

[chapulina]

This unfortunately reduces the overall test coverage % because various ogre1.x code is not run any more.

If we're not planning to test both engines, then we should exclude the other one from test coverage. I think we should test all engines that we officially support though. What do you think?

[iche033]

I think we should test all engines that we officially support though.

The problem we ran into before was that we were not able to run ogre and ogre2 tests in the same process, i.e. one after another since the plugins can't be loaded at the same time. We could look into generating tests for each render engine so that they are run in separate processes, e.g. UNIT_ogre_Scene_TEST and UNIT_ogre2_Scene_TEST.

[chapulina]

How about we ticket an issue for that, and for now we exclude Ogre1 and Optix from the coverage reports?

[iche033]

How about we ticket an issue for that, and for now we exclude Ogre1 and Optix from the coverage reports?

yep ticketed #683 and created #684 to ignore certain folders in test coverage