Merge ign-rendering2 to ign-rendering3

[iche033]

Merging forward 2 to 3 so we can run ogre2 tests with the latest depth camera noise changes on jenkins

[codecov]

Codecov Report

Merging #130 into ign-rendering3 will increase coverage by 0.59%.
The diff coverage is 93.50%.

@@                Coverage Diff                 @@
##           ign-rendering3     #130      +/-   ##
==================================================
+ Coverage           49.82%   50.41%   +0.59%     
==================================================
  Files                 129      129              
  Lines               11526    11682     +156     
==================================================
+ Hits                 5743     5890     +147     
- Misses               5783     5792       +9     

Impacted Files	Coverage Δ
ogre2/src/Ogre2RenderTarget.cc	73.67% <91.66%> (+0.49%)	⬆️
ogre2/src/Ogre2DepthCamera.cc	93.63% <93.42%> (-0.61%)	⬇️
ogre2/src/Ogre2GaussianNoisePass.cc	90.00% <95.83%> (+6.66%)	⬆️

---

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 640d623...963e583. Read the comment docs.

[iche033]

depth and render pass test also failed here. Marking this PR as draft for debugging

[iche033]

@osrf-jenkins run tests please

[iche033]

@osrf-jenkins run tests please

[iche033]

Ready for review. Ubuntu tests are passing now and I disabled the render_pass integration test in homebrew like we did for the depth camera integration test.

[chapulina]

Changes LGTM. I'm just concerned about the Windows build. " Build finished. No test results found. " usually means the compilation failed, but at the moment build.osrf isn't reachable.

[iche033]

the windows machine could be in a bad state. I had to go in from time to time and remove the build directory for the next build to pass. I'll give that a try

[iche033]

@osrf-jenkins run tests please

[chapulina]

The Windows build is indeed broken and I'm not sure exactly why. I triggered a Windows build of ign-rendering3 just to have a baseline:

[iche033]

@osrf-jenkins run tests please

[iche033]

The Windows build is indeed broken and I'm not sure exactly why

I logged into the machine and found that one of the installed ign-common header files is corrupt and had weird characters in it. I deleted the install dir and started another round of builds

[iche033]

ok deleting the cached files on the windows CI machine worked. Latest ign-rendering build finished with 2 unrelated test failures

[chapulina]

I squashed all the commits that were made on top of the merge, ending at 963e583. For some reason git didn't keep the original author, sorry @iche033 😕 I'm still figuring out the best way of handling this. And also it looks like I caused some regression on the CI tests, so ultimate #fail 😢

[chapulina]

Reverted the PR back to its original state. I think we can merge it like this unless someone is inclined to try squashing all those commits again.

[iche033]

I'm good as is. Let's merge it!

[chapulina]

humm so, now the Ubuntu CI has 14 test failures again. I thought I had introduced those with my git gymnastics. Are they expected?

[iche033]

No the test failures are not expected. Not sure what happened as the ubuntu builds have been green when I was fixing the window builds. I'll need to take a closer look.

[iche033]

@osrf-jenkins run tests please

[iche033]

the latest ubuntu build passed. I think tests started failing on r2d2.nv.xenial recently. I see that the rendering tests are also failing in ign-gazebo with the same unsupported framebuffer format ogre error when run on r2d2, e.g. this one. I've seen those errors before and usually it's an issue with the graphics driver. I logged onto r2d2 and but couldn't tell if there were any changes in configuration recently. We can try updating the nvidia driver on r2d2 and see if it helps