Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve particle scattering noise #261

Merged
merged 8 commits into from
Mar 2, 2021
Merged

Improve particle scattering noise #261

merged 8 commits into from
Mar 2, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Mar 2, 2021

🦟 Bug fix

Summary

Applies more uniform random scattering based on size of the particle emitter region (instead of the first particle hit)

Affects depth, rgbd, and gpu_rays sensors

To test

You can test with ign gazebo using this sensor_particles_scattering.sdf world

ign gazebo -v 4 -r sensor_particles_scattering.sdf

You can see the lidar visualization by using the Visualize Lidar plugin. Top Right menu -> Visualize Lidar

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge

@iche033 iche033 marked this pull request as draft March 2, 2021 00:25
@github-actions github-actions bot added the 🔮 dome Ignition Dome label Mar 2, 2021
@iche033 iche033 requested a review from nkoenig March 2, 2021 01:34
@iche033 iche033 marked this pull request as ready for review March 2, 2021 05:57
@iche033 iche033 merged commit fff0dbd into ign-rendering4 Mar 2, 2021
@iche033 iche033 deleted the particle_noise branch March 2, 2021 06:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants