Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merge 3 -> 4 #423

Merged
merged 4 commits into from
Sep 24, 2021
Merged

Merge 3 -> 4 #423

merged 4 commits into from
Sep 24, 2021

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Sep 23, 2021

➡️ Forward port

Port ign-rendering3 to ign-rendering4

Branch comparison: ign-rendering4...ign-rendering3

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

j-rivero and others added 3 commits September 16, 2021 16:13
@iche033 iche033 added the 🔮 dome Ignition Dome label Sep 23, 2021
Signed-off-by: Ian Chen <[email protected]>
@codecov
Copy link

codecov bot commented Sep 24, 2021

Codecov Report

Merging #423 (85f4b58) into ign-rendering4 (29876ec) will decrease coverage by 2.33%.
The diff coverage is n/a.

Impacted file tree graph

@@                Coverage Diff                 @@
##           ign-rendering4     #423      +/-   ##
==================================================
- Coverage           56.32%   53.99%   -2.34%     
==================================================
  Files                 147      147              
  Lines               14119    14119              
==================================================
- Hits                 7952     7623     -329     
- Misses               6167     6496     +329     
Impacted Files Coverage Δ
ogre2/src/Ogre2MaterialSwitcher.cc 0.00% <0.00%> (-90.00%) ⬇️
ogre2/src/Ogre2SelectionBuffer.cc 0.00% <0.00%> (-87.40%) ⬇️
ogre2/src/Ogre2RayQuery.cc 73.46% <0.00%> (-20.41%) ⬇️
ogre2/src/Ogre2Camera.cc 71.20% <0.00%> (-16.80%) ⬇️
src/Utils.cc 74.73% <0.00%> (-10.53%) ⬇️
...e/ignition/rendering/base/BaseGaussianNoisePass.hh 96.66% <0.00%> (-3.34%) ⬇️
src/base/BaseScene.cc 72.96% <0.00%> (-2.30%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 29876ec...85f4b58. Read the comment docs.

@iche033
Copy link
Contributor Author

iche033 commented Sep 24, 2021

disabled VisualAt test that's consistently failing, and added comment referencing #170. 85f4b58

@iche033 iche033 merged commit 4c11cc2 into ign-rendering4 Sep 24, 2021
@iche033 iche033 deleted the merge_3_4_09232021 branch September 24, 2021 05:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🔮 dome Ignition Dome
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants