Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make rendering sensors' HasConnections function virtual #234

Merged
merged 5 commits into from
Jul 7, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 8, 2022

🎉 New feature

Summary

Addresses the todo item about making the HasConnection() virtual, specifically,

  • Adds a base virtual bool HasConnection() const function to RenderingSensor
  • Updates all derived sensors to override the base RenderingSensor class
  • Adds HasConnections() to the WideAngleCamera class

Checklist

  • Signed all commits for DCO
  • Added tests
  • Added example and/or tutorial
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@codecov
Copy link

codecov bot commented Jun 8, 2022

Codecov Report

Merging #234 (d1bcce0) into main (075123d) will decrease coverage by 0.10%.
The diff coverage is 0.00%.

@@            Coverage Diff             @@
##             main     #234      +/-   ##
==========================================
- Coverage   68.68%   68.58%   -0.11%     
==========================================
  Files          34       34              
  Lines        3423     3428       +5     
==========================================
  Hits         2351     2351              
- Misses       1072     1077       +5     
Impacted Files Coverage Δ
include/gz/sensors/ForceTorqueSensor.hh 100.00% <ø> (ø)
include/gz/sensors/NavSatSensor.hh 100.00% <ø> (ø)
src/Sensor.cc 91.25% <0.00%> (-1.01%) ⬇️
src/WideAngleCameraSensor.cc 0.00% <0.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 075123d...d1bcce0. Read the comment docs.

@chapulina chapulina requested a review from ahcorde June 27, 2022 18:57
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ups, some tests are not passing

@iche033
Copy link
Contributor Author

iche033 commented Jul 7, 2022

ups, some tests are not passing

ok homebrew build is now green. d1bcce0

the Jammy rendering test failures have been happening for some time and I think they are not related to the changes here.

@chapulina chapulina merged commit f17ac32 into main Jul 7, 2022
@chapulina chapulina deleted the rs_has_connections branch July 7, 2022 15:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants