-
Notifications
You must be signed in to change notification settings - Fork 59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Make rendering sensors' HasConnections function virtual #234
Conversation
Signed-off-by: Ian Chen <[email protected]>
Codecov Report
@@ Coverage Diff @@
## main #234 +/- ##
==========================================
- Coverage 68.68% 68.58% -0.11%
==========================================
Files 34 34
Lines 3423 3428 +5
==========================================
Hits 2351 2351
- Misses 1072 1077 +5
Continue to review full report at Codecov.
|
Signed-off-by: Ian Chen <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ups, some tests are not passing
Signed-off-by: Ian Chen <[email protected]>
ok homebrew build is now green. d1bcce0 the Jammy rendering test failures have been happening for some time and I think they are not related to the changes here. |
🎉 New feature
Summary
Addresses the todo item about making the
HasConnection()
virtual, specifically,virtual bool HasConnection() const
function toRenderingSensor
HasConnections()
to theWideAngleCamera
classChecklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.