Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use base RenderingSensor::HasConnections function in sensors system #1528

Merged
merged 1 commit into from
Jul 19, 2022

Conversation

iche033
Copy link
Contributor

@iche033 iche033 commented Jun 8, 2022

🦟 Bug fix

Depends on gazebosim/gz-sensors#234

Summary

Use the new RenderingSensor::HasConnections function introduced in gazebosim/gz-sensors#234. This avoids checking the sensor type by doing explicit casts which was previously done for ABI compatibility.

This should also fix the WideAngleCamera integration test.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@iche033 iche033 mentioned this pull request Jun 8, 2022
8 tasks
@chapulina chapulina added 🌱 garden Ignition Garden needs upstream release Blocked by a release of an upstream library labels Jun 13, 2022
@chapulina chapulina requested a review from ahcorde June 27, 2022 18:57
@scpeters
Copy link
Member

conflicts

@chapulina chapulina removed the needs upstream release Blocked by a release of an upstream library label Jul 18, 2022
@iche033 iche033 force-pushed the rs_has_connections branch from 6d86600 to 9648643 Compare July 18, 2022 21:55
@iche033
Copy link
Contributor Author

iche033 commented Jul 18, 2022

conflicts

should be resolved now

@iche033
Copy link
Contributor Author

iche033 commented Jul 19, 2022

hmm there is a build error in the homebrew build when compiling INTEGRATION_scene_broadcaster_system that I think it's not related.

@iche033
Copy link
Contributor Author

iche033 commented Jul 19, 2022

hmm there is a build error in the homebrew build when compiling INTEGRATION_scene_broadcaster_system that I think it's not related.

looks like it's fixed in #1599. Needs to be forward ported

@scpeters
Copy link
Member

hmm there is a build error in the homebrew build when compiling INTEGRATION_scene_broadcaster_system that I think it's not related.

looks like it's fixed in #1599. Needs to be forward ported

#1603

@chapulina chapulina merged commit 33c82e9 into main Jul 19, 2022
@chapulina chapulina deleted the rs_has_connections branch July 19, 2022 23:33
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

4 participants