Renamed ignition_frame_id to gz_frame_id and fix warning

[ahcorde]

Signed-off-by: Alejandro Hernández Cordero [email protected]

🦟 Bug fix

Summary

Renamed ignition_frame_id to gz_frame_id and fix warning

Checklist

• Signed all commits for DCO
• Added tests
• Updated documentation (as needed)
• Updated migration guide (as needed)
• Consider updating Python bindings (if the library has them)
• codecheck passed (See contributing)
• All tests passed (See test coverage)
• While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

[codecov]

Codecov Report

Merging #296 (4bb4c3e) into gz-sensors7 (8e8dfa8) will decrease coverage by 0.04%.
The diff coverage is 57.14%.

@@               Coverage Diff               @@
##           gz-sensors7     #296      +/-   ##
===============================================
- Coverage        69.24%   69.19%   -0.05%     
===============================================
  Files               35       35              
  Lines             3749     3753       +4     
===============================================
+ Hits              2596     2597       +1     
- Misses            1153     1156       +3     

Impacted Files	Coverage Δ
src/Sensor.cc	89.83% <57.14%> (-1.42%)	⬇️

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[azeey]

We've been bitten in the past where we deprecated something and removes tests that use the deprecated item. Could you add a test that still uses ignition_frame_id? Otherwise, LGTM!

[ahcorde]

We've been bitten in the past where we deprecated something and removes tests that use the deprecated item. Could you add a test that still uses ignition_frame_id? Otherwise, LGTM!

In the Gazebo lLibraries I would say this is not used, I will check in ros_gz.

Look good to @azeey too