Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added thermal camera tutorial #61

Merged
merged 1 commit into from
Nov 18, 2020

Conversation

adlarkin
Copy link
Contributor

@adlarkin adlarkin commented Nov 9, 2020

I've moved the thermal camera sensor tutorial over from osrf/ign-gazebo to this repository since it's a sensor tutorial.

Depends on gazebosim/gz-sim#442.

Signed-off-by: Ashton Larkin [email protected]

@adlarkin adlarkin requested review from nkoenig and iche033 November 9, 2020 22:57
@adlarkin adlarkin requested a review from maryaB-osr as a code owner November 9, 2020 22:57
@github-actions github-actions bot added the 🏰 citadel Ignition Citadel label Nov 9, 2020
@adlarkin
Copy link
Contributor Author

adlarkin commented Nov 9, 2020

When I was writing this tutorial originally in osrf/ign-gazebo, @iche033 recommended that I use @image to get images uploaded to the ignition robotics website (relevant comment here). This seemed to work fine for me in osrf/ign-gazebo, but for some reason, the images don't seem to render using @image with doxygen when I test this tutorial in osrf/ign-sensors. Can someone else test this to see if the tutorial appears correctly for them on the ignition robotics website? And if it doesn't work for anyone else, why would @image only work in osrf/ign-gazebo?

@codecov
Copy link

codecov bot commented Nov 9, 2020

Codecov Report

Merging #61 (eec1461) into ign-sensors3 (f989fdd) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@              Coverage Diff              @@
##           ign-sensors3      #61   +/-   ##
=============================================
  Coverage         77.54%   77.54%           
=============================================
  Files                23       23           
  Lines              2298     2298           
=============================================
  Hits               1782     1782           
  Misses              516      516           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f989fdd...ea03923. Read the comment docs.

tutorials/thermal_camera.md Outdated Show resolved Hide resolved
tutorials/thermal_camera.md Outdated Show resolved Hide resolved
@chapulina
Copy link
Contributor

And if it doesn't work for anyone else, why would @image only work in osrf/ign-gazebo?

You need to add these lines here:

https://github.com/ignitionrobotics/ign-gazebo/blob/990e4f240bbb3246a0e1d0c89b74e0ef8f109b4b/CMakeLists.txt#L175-L177

@adlarkin adlarkin force-pushed the adlarkin/thermal_camera_tutorial branch from fb8c3c4 to dad3c29 Compare November 16, 2020 22:35
@adlarkin
Copy link
Contributor Author

Review comments have been addressed, and image/example code display issues in the tutorial have also been resolved. I believe this is ready for final review.

Copy link
Contributor

@nkoenig nkoenig left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just one change

tutorials.md.in Outdated Show resolved Hide resolved
@adlarkin adlarkin requested a review from iche033 November 18, 2020 01:33
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me!

@adlarkin adlarkin force-pushed the adlarkin/thermal_camera_tutorial branch from eec1461 to ea03923 Compare November 18, 2020 12:54
@adlarkin adlarkin merged commit ea03923 into ign-sensors3 Nov 18, 2020
@adlarkin adlarkin deleted the adlarkin/thermal_camera_tutorial branch November 18, 2020 12:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏰 citadel Ignition Citadel
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants