Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Physics System should Populate/Update all velocity/acceleration components for non-link entities #1866

Closed
ejalaa12 opened this issue Jan 23, 2023 · 0 comments · Fixed by #1868
Labels
enhancement New feature or request

Comments

@ejalaa12
Copy link
Contributor

While implementing a custom sensor, i noticed that the physics system only updates the following velocity/acceleration components:

  • WorldPose
  • WorldLinearVelocity
  • AngularVelocity
  • LinearAcceleration

I'm guessing this was an initial need for the Imu Sensor.

Desired behavior

Other custom sensor might want to exploit the missing following components:

  • WorldAngularVelocity
  • LinearVelocity
  • WorldLinearAcceleration
  • WorldAngularAcceleration
  • AngularAcceleration

Alternatives considered

It could be possible to re-compute and update those Component from the custom sensor. This is what the Odometry system does through the "xyz_offset" and "rpy_offset" parameters.

But it would be cleaner to actually have the Physics system compute and populate them since it is already doing it partly.

Implementation suggestion

I could propose a PR to make the Physics system also compute the missing velocities/accelerations.

Additional context

Is there a reason why this was not already implemented ?

@ejalaa12 ejalaa12 added the enhancement New feature or request label Jan 23, 2023
ejalaa12 added a commit to ejalaa12/gz-sim that referenced this issue Jan 24, 2023
ejalaa12 added a commit to ejalaa12/gz-sim that referenced this issue Feb 14, 2023
ejalaa12 added a commit to ejalaa12/gz-sim that referenced this issue Feb 28, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant