Create expanding type header to reduce code duplication #1169
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ent inspector Signed-off-by: Nate Koenig <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>
Codecov Report
@@ Coverage Diff @@
## ign-gazebo6 #1169 +/- ##
===============================================
+ Coverage 62.15% 62.18% +0.02%
===============================================
Files 256 256
Lines 20355 20355
===============================================
+ Hits 12651 12657 +6
+ Misses 7704 7698 -6
Continue to review full report at Codecov.
|
iche033
reviewed
Nov 5, 2021
Signed-off-by: Nate Koenig <[email protected]>
iche033
changed the title
iche033
approved these changes
Nov 5, 2021
WilliamLewww
pushed a commit
to WilliamLewww/ign-gazebo
that referenced
this pull request
Dec 7, 2021
* Create exanpding type header to reduce code duplication in the component inspector Signed-off-by: Nate Koenig <[email protected]> * Revert TypeHeader changes Signed-off-by: Nate Koenig <[email protected]> * Removed extra lines Signed-off-by: Nate Koenig <[email protected]> Co-authored-by: Nate Koenig <[email protected]> Signed-off-by: William Lew <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Nate Koenig [email protected]
🎉 New feature
Summary
Reduce code duplication in component inspector QML files by adding an ExpandingTypeHeader.qml element.
Test it
Run the component inspector, and try expanding elements such as Pose and Light.
Checklist
codecheckpassed (See contributing)Note to maintainers: Remember to use Squash-Merge