Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

5 ➡️ 6 #1277

Merged
merged 14 commits into from
Jan 12, 2022
Merged

5 ➡️ 6 #1277

merged 14 commits into from
Jan 12, 2022

Conversation

chapulina
Copy link
Contributor

➡️ Forward port

Port ign-gazebo5 to ign-gazebo6

Branch comparison: ign-gazebo6...gazebo5

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

azeey and others added 13 commits November 15, 2021 18:03
Signed-off-by: Addisu Z. Taddese <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
* Support battery draining start via topics

Signed-off-by: Nate Koenig <[email protected]>

* Added more documentation and a todo item

Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
* Make tests run as fast as possible (#1194)

Signed-off-by: Louise Poubel <[email protected]>

* [Dome] Make tests run as fast as possible (#1250)

Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina requested a review from azeey as a code owner January 10, 2022 22:27
@github-actions github-actions bot added the 🏯 fortress Ignition Fortress label Jan 10, 2022
Copy link
Contributor

@iche033 iche033 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like IGN_UTILS_TEST_DISABLED_ON_WIN32 is causing compile erros.

@codecov
Copy link

codecov bot commented Jan 12, 2022

Codecov Report

Merging #1277 (db38ea9) into ign-gazebo6 (fe335f9) will increase coverage by 0.24%.
The diff coverage is 94.73%.

Impacted file tree graph

@@               Coverage Diff               @@
##           ign-gazebo6    #1277      +/-   ##
===============================================
+ Coverage        61.97%   62.21%   +0.24%     
===============================================
  Files              276      276              
  Lines            23000    23016      +16     
===============================================
+ Hits             14254    14320      +66     
+ Misses            8746     8696      -50     
Impacted Files Coverage Δ
src/systems/battery_plugin/LinearBatteryPlugin.cc 62.87% <93.33%> (+22.07%) ⬆️
src/SimulationRunner.cc 92.37% <100.00%> (+0.02%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fe335f9...db38ea9. Read the comment docs.

@chapulina chapulina merged commit 4dea262 into ign-gazebo6 Jan 12, 2022
@chapulina chapulina deleted the chapulina/5_to_6 branch January 12, 2022 17:30
@chapulina chapulina mentioned this pull request Jan 12, 2022
7 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🏯 fortress Ignition Fortress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants