Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

6 ➡️ 7 (main) (partial) #1437

Merged
merged 39 commits into from
Apr 13, 2022
Merged

6 ➡️ 7 (main) (partial) #1437

merged 39 commits into from
Apr 13, 2022

Conversation

chapulina
Copy link
Contributor

6 ➡️ 7

Doing a partial port because @azeey will cherry-pick #1317 and fix conflicts. Then after this PR and that cherry-pick, I can forward-port the rest.

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

chapulina and others added 30 commits March 4, 2022 08:28
@chapulina @ahcorde
GzSceneManager: Prevent crash 💥 when inserted from menu (#1371)
b8f8b53 
Signed-off-by: Louise Poubel <[email protected]>
Signed-off-by: ahcorde <[email protected]>

Co-authored-by: ahcorde <[email protected]>
@j-rivero
Prepare version 6.7.0 (#1373)
cf58595 
* Prepare version 6.7.0

Signed-off-by: Jose Luis Rivero <[email protected]>
@chapulina
Populate GUI plugins that are empty (#1375)
6d03889 
Signed-off-by: Louise Poubel <[email protected]>
@ahcorde
Fix visualization python tutorial (#1377)
f5bb284 
Signed-off-by: ahcorde <[email protected]>
@adityapande-1995
Add xyz and rpy offset to published odometry pose (#1341)
c24a4e9 
* Added xyz and rpy offset to published pose

Signed-off-by: Aditya <[email protected]>
@nkoenig @chapulina @adityapande-1995
Added headless rendering tutorial (#1386)
0f45c17 
* Added headless rendering tutorial

Signed-off-by: Nate Koenig <[email protected]>

* Update tutorials/headless_rendering.md

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

* Update tutorials/headless_rendering.md

Co-authored-by: Louise Poubel <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

* Mention ogre2

Signed-off-by: Nate Koenig <[email protected]>

* Added note about software rendering

Signed-off-by: Nate Koenig <[email protected]>

* add 'on linux systems'

Signed-off-by: Nate Koenig <[email protected]>

* Add xyz and rpy offset to published odometry pose (#1341)

* Added xyz and rpy offset to published pose

Signed-off-by: Aditya <[email protected]>
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
Co-authored-by: Aditya Pande <[email protected]>
@ahcorde @chapulina
Allow to turn on/off lights (#1343)
30f8b9e 
Signed-off-by: ahcorde <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
@iche033 @nkoenig @ahcorde
Add gazebo Entity id to rendering sensor's user data (#1381)
a9563f5 
Adds the gazebo::Entity id to a rendering::Sensor's UserData object. The main use case is so that we can get back the corresponding gazebo Entity in the rendering thread when processing sensors.

Signed-off-by: Ian Chen <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@adlarkin
Don't mark entities with a ComponentState::NoChange component as modi…
b6a1133 
…fied (#1391)

Signed-off-by: Ashton Larkin <[email protected]>
@azeey
Disable ModelCommandAPI_TEST.RgbdCameraSensor on macOS (#1397)
252f99b 
Disabling test since it's very flaky.

Signed-off-by: Addisu Z. Taddese <[email protected]>
@azeey
Disable PeerTracker.PeerTrackerStale on macOS (#1398)
65fcbfd 
Signed-off-by: Addisu Z. Taddese <[email protected]>
@ahcorde
Toggle Light visuals (#1387)
1231d49 
Signed-off-by: ahcorde <[email protected]>
@chapulina @ahcorde
Prevent hanging when world has only non-world plugins (#1383)
3106687 
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@chapulina
Component inspector: refactor Pose3d C++ code into a separate class (#…
6feba08 
…1400)

Signed-off-by: Louise Poubel <[email protected]>
@iche033
add initial_position param to joint controller system (#1406)
e4b2cfc 
Similar to the <initial_position> parameter in the JointTrajectoryController system, this PR adds an <initial_position> parameter to the JointPositionController to let users specifies the initial target pos for a joint.

Signed-off-by: Ian Chen <[email protected]>
@iche033
Fix JointStatePublisher topic name for nested models (#1405)
c02e140 
The joint-state-publisher system currently assumes it's always attached to the top level model and hence generates an incorrect topic name for nested models. This PR updates it to generate the correct topic name.

Signed-off-by: Ian Chen <[email protected]>
@ahcorde @chapulina
Added user command to set multiple entities (#1394)
1fa99f4 
Signed-off-by: ahcorde <[email protected]>
Signed-off-by: Louise Poubel <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@chapulina
3 ➡️ 5
7f1fb93 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Disable tests that are expected to fail on Windows (#1408)
dad34de 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
3 ➡️ 5 (#1408)
c3c868d 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
Fortress: Install Ogre 2.2, simplify docker (#1395)
9b07b24 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina
5 ➡️ 6
1b3847f 
Signed-off-by: Louise Poubel <[email protected]>
@adlarkin @chapulina
SceneBroadcaster: only send changed state information for change even…
0996fe0 
…ts (#1392)

Signed-off-by: Ashton Larkin <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@ivanpauno
Add wheel slip user command (#1241)
adeb304 
Signed-off-by: Ivan Santiago Paunovic <[email protected]>
@ahcorde
Merge branch 'ign-gazebo6' into chapulina/5_to_6
685a11f
@chapulina
5 ➡️ 6 (#1413)
4121a5c 
Signed-off-by: Louise Poubel <[email protected]>
@WilliamLewww @ahcorde @chapulina
Distortion camera integration test (#1374)
2449e80 
Signed-off-by: William Lew <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
Co-authored-by: Louise Poubel <[email protected]>
@marcoag
Add the Model Photo Shoot system, port of Modelpropshop plugin from G…
3458318 
…azebo classic (#1331)

This system can be used to generate thumbnails of models. In comparison to the Modelpropshop plugin in Gazebo classic, this adds the ability to generate thumbnails after randomizing the joint positions of the model.

Signed-off-by: Marco A. Gutierrez <[email protected]>
Signed-off-by: Addisu Z. Taddese <[email protected]>
@chapulina
Referring to Fuel assets within a heightmap (#1419)
5503a5c 
Signed-off-by: Louise Poubel <[email protected]>
@iche033
Disable sensors in sensors system when battery is drained (#1385)
32bc612 
Added a new parameter <disable_on_drained_battery> to the sensors system. If set to true, sensors will be disabled if the model is out of battery.

It listens to the battery state of charge from the battery plugin, and if the charge reaches zero, all child sensors and nested sensors are set to be inactive.

Signed-off-by: Ian Chen <[email protected]>
chapulina and others added 7 commits March 31, 2022 16:41
@chapulina
🏁🎈 5.4.0 (#1420)
dc3ae71 
Signed-off-by: Louise Poubel <[email protected]>
@nkoenig @mjcarroll @ahcorde
ServerConfig accepts an sdf::Root DOM object (#1333)
39a0ce3 
Signed-off-by: Nate Koenig <[email protected]>

Co-authored-by: Nate Koenig <[email protected]>
Co-authored-by: Michael Carroll <[email protected]>
Co-authored-by: Alejandro Hernández Cordero <[email protected]>
@chapulina
5 ➡️ 6
8c8c7fa 
Signed-off-by: Louise Poubel <[email protected]>
@j-rivero
Merge pull request #1422 from ignitionrobotics/chapulina/5_to_6
207d079 
5 ➡️ 6
@j-rivero
Preparing 6.8.0 release (#1425)
eb38961 
* Prepareing 6.8.0 release

Signed-off-by: Jose Luis Rivero <[email protected]>

* Update changelog after merging forward port

Signed-off-by: Jose Luis Rivero <[email protected]>
@adityapande-1995 @chapulina
Add Gaussian noise to Odometry Publisher (#1393)
d01652c 
* Added gaussian noise and odometry with covariance publisher

Signed-off-by: Aditya <[email protected]>

Co-authored-by: Louise Poubel <[email protected]>
@chapulina
6 ➡️ 7 (main) (partial)
82b1f3a 
Signed-off-by: Louise Poubel <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Apr 12, 2022
@chapulina chapulina mentioned this pull request Apr 12, 2022
Merged
10 tasks
@codecov
Copy link

codecov bot commented Apr 12, 2022 •
edited
Loading

Codecov Report

Merging #1437 (1fb55b4) into main (b2549dd) will decrease coverage by 0.37%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##             main    #1437      +/-   ##
==========================================
- Coverage   35.39%   35.01%   -0.38%     
==========================================
  Files          43       44       +1     
  Lines        2331     2356      +25     
==========================================
  Hits          825      825              
- Misses       1506     1531      +25
Impacted Files Coverage Δ
src/gui/plugins/spawn/qrc_Spawn.cpp 100.00% <0.00%> (ø)
...c/gui/plugins/scene_manager/qrc_GzSceneManager.cpp 100.00% <0.00%> (ø)
...gui/plugins/select_entities/qrc_SelectEntities.cpp 100.00% <0.00%> (ø)
...ins/component_inspector/qrc_ComponentInspector.cpp 100.00% <0.00%> (ø)
...ntity_context_menu/qrc_EntityContextMenuPlugin.cpp 100.00% <0.00%> (ø)
...ion_capabilities/qrc_VisualizationCapabilities.cpp 100.00% <0.00%> (ø)
src/gui/plugins/component_inspector/moc_Pose3d.cpp 0.00% <0.00%> (ø)
...ins/component_inspector/moc_ComponentInspector.cpp 9.27% <0.00%> (+0.06%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b2549dd...1fb55b4. Read the comment docs.

chapulina added a commit that referenced this pull request Apr 13, 2022
@chapulina
Fix deprecation warnings for ModelPhotoShoot (#1437)
628903c 
Signed-off-by: Louise Poubel <[email protected]>
@chapulina chapulina merged commit c660c87 into main Apr 13, 2022
@chapulina chapulina deleted the chapulina/6_to_7 branch April 13, 2022 18:59
@hidmic
Copy link
Contributor

hidmic commented Apr 20, 2022

@azeey @chapulina how far are we from completing the forward port?

@chapulina
Copy link
Contributor Author

@azeey @chapulina how far are we from completing the forward port?

See #1446, just need a review

@j-rivero j-rivero mentioned this pull request Sep 16, 2022
Merged
3 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ahcorde ahcorde ahcorde approved these changes

@mabelzhang mabelzhang Awaiting requested review from mabelzhang mabelzhang is a code owner

@iche033 iche033 Awaiting requested review from iche033 iche033 is a code owner

@azeey azeey Awaiting requested review from azeey azeey is a code owner

Assignees
No one assigned
Labels
🌱 garden Ignition Garden
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.