Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix display of Pose3d and Vector3d on macOS #1680

Merged
merged 1 commit into from
Sep 13, 2022

Conversation

srmainwaring
Copy link
Contributor

This PR fixes the display of Pose3d and Vector3d on macOS.

🦟 Bug fix

Fixes #1668

Summary

The fix sets an additional layout attribute Layout.preferredWidth: parent.width to the GzPose and GzVector3 declarations in Pose3d.qml and Vector3d.qml of the component inspector. Without these the entries render empty on macOS / Metal.

Further details and tests are provided in #1668.

Checklist

  • [ x ] Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • [ x ] codecheck passed (See contributing)
  • [ x ] All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

- Pose3d and Vector3d were not displaying on macOS

Signed-off-by: Rhys Mainwaring <[email protected]>
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Aug 30, 2022
Copy link
Contributor

@ahcorde ahcorde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It fixed partially the problem, I can only see the value if I click on the box

Captura de pantalla 2022-08-30 a las 14 01 41

@chapulina chapulina added bug Something isn't working GUI Gazebo's graphical interface (not pure Ignition GUI) macOS macOS support labels Aug 30, 2022
@srmainwaring
Copy link
Contributor Author

It fixed partially the problem, I can only see the value if I click on the box

That's interesting - I don't see that behaviour on an intel mac. What system are you running @ahcorde? I have an M1 MacBook I can try to test on as well.

@ahcorde
Copy link
Contributor

ahcorde commented Aug 30, 2022

It fixed partially the problem, I can only see the value if I click on the box

That's interesting - I don't see that behaviour on an intel mac. What system are you running @ahcorde? I have an M1 MacBook I can try to test on as well.

MacBook Pro Retina middle 2014. Big Sur 11.6.8

Maybe something wrong in my configuration ?

@ahcorde ahcorde merged commit a853e5d into gazebosim:gz-sim7 Sep 13, 2022
@j-rivero j-rivero mentioned this pull request Sep 16, 2022
3 tasks
@srmainwaring srmainwaring deleted the srmainwaring/pose3d-macos branch January 29, 2023 13:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working 🌱 garden Ignition Garden GUI Gazebo's graphical interface (not pure Ignition GUI) macOS macOS support
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants