Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update examples to used gazebosim #1726

Merged
merged 1 commit into from
Oct 3, 2022
Merged

Update examples to used gazebosim #1726

merged 1 commit into from
Oct 3, 2022

Conversation

nkoenig
Copy link
Contributor

@nkoenig nkoenig commented Sep 21, 2022

Signed-off-by: Nate Koenig [email protected]

🦟 Bug fix

Summary

Use gazebosim.org in the example worlds. This also updates a few deprecated uses of ignition-gui and API documentation links.

Merge after the garden release.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@nkoenig nkoenig marked this pull request as draft September 21, 2022 18:50
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Sep 21, 2022
@codecov
Copy link

codecov bot commented Sep 21, 2022

Codecov Report

Merging #1726 (247360b) into gz-sim7 (0df8e9e) will not change coverage.
The diff coverage is n/a.

@@           Coverage Diff            @@
##           gz-sim7    #1726   +/-   ##
========================================
  Coverage    63.93%   63.93%           
========================================
  Files          334      334           
  Lines        26333    26333           
========================================
  Hits         16836    16836           
  Misses        9497     9497           
Impacted Files Coverage Δ
include/gz/sim/EntityComponentManager.hh 100.00% <ø> (ø)

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

Copy link
Contributor

@mjcarroll mjcarroll left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, is this being held to patch release 1?

@nkoenig nkoenig marked this pull request as ready for review October 3, 2022 18:24
@nkoenig nkoenig merged commit 2f10426 into gz-sim7 Oct 3, 2022
@nkoenig nkoenig deleted the examples-ign-gz branch October 3, 2022 18:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants