Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removed warnings #1752

Closed
wants to merge 1 commit into from
Closed

Removed warnings #1752

wants to merge 1 commit into from

Conversation

ahcorde
Copy link
Contributor

@ahcorde ahcorde commented Oct 10, 2022

Signed-off-by: ahcorde [email protected]

🦟 Bug fix

Fixes #

Summary

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@ahcorde
Removed warnings
1c8b2bb 
Signed-off-by: ahcorde <[email protected]>
@ahcorde ahcorde self-assigned this Oct 10, 2022
@ahcorde ahcorde requested a review from mjcarroll as a code owner October 10, 2022 13:30
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Oct 10, 2022
@mjcarroll
Copy link
Contributor

Should this be targeted to an older version, or are these warnings unique to gz-sim7?

@ahcorde
Copy link
Contributor Author

ahcorde commented Oct 10, 2022

Should this be targeted to an older version, or are these warnings unique to gz-sim7?

Closing this PR is favour of #1754 and #1753

@ahcorde ahcorde closed this Oct 10, 2022
@mjcarroll mjcarroll deleted the ahcorde/7/compile_warnnings branch October 10, 2022 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mjcarroll mjcarroll Awaiting requested review from mjcarroll mjcarroll is a code owner

Assignees

@ahcorde ahcorde

Labels
🌱 garden Ignition Garden
Projects
Core development
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ahcorde @mjcarroll