Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removed warnings #1752

Closed
wants to merge 1 commit into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/Util_TEST.cc
Original file line number Diff line number Diff line change
Expand Up @@ -824,7 +824,7 @@ TEST_F(UtilTest, EntityFromMsg)
ecm.CreateComponent(actorDEntity, components::ParentEntity(worldEntity));

// Check entities
auto createMsg = [&ecm](Entity _id, const std::string &_name = "",
auto createMsg = [](Entity _id, const std::string &_name = "",
msgs::Entity::Type _type = msgs::Entity::NONE) -> msgs::Entity
{
msgs::Entity msg;
Expand Down
1 change: 0 additions & 1 deletion src/systems/altimeter/Altimeter.cc
Original file line number Diff line number Diff line change
Expand Up @@ -261,7 +261,6 @@ void AltimeterPrivate::UpdateAltimeters(const EntityComponentManager &_ecm)
auto it = this->entitySensorMap.find(_entity);
if (it != this->entitySensorMap.end())
{
math::Vector3d linearVel;
math::Pose3d worldPose = _worldPose->Data();
it->second->SetPosition(worldPose.Pos().Z());
it->second->SetVerticalVelocity(_worldLinearVel->Data().Z());
Expand Down
2 changes: 1 addition & 1 deletion src/systems/camera_video_recorder/CameraVideoRecorder.hh
Original file line number Diff line number Diff line change
Expand Up @@ -51,7 +51,7 @@ namespace systems
///
/// <bitrate> Video recorder bitrate (bps). The default value is
/// 2070000 bps, and the supported type is unsigned int.
class CameraVideoRecorder:
class CameraVideoRecorder final:
public System,
public ISystemConfigure,
public ISystemPostUpdate
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -614,8 +614,7 @@ void OpticalTactilePluginPrivate::Load(const EntityComponentManager &_ecm)
this->sensorSize,
this->forceLength,
this->cameraUpdateRate,
this->depthCameraOffset,
this->visualizationResolution);
this->depthCameraOffset);

this->initialized = true;
}
Expand Down
6 changes: 2 additions & 4 deletions src/systems/optical_tactile_plugin/Visualization.cc
Original file line number Diff line number Diff line change
Expand Up @@ -32,14 +32,12 @@ OpticalTactilePluginVisualization::OpticalTactilePluginVisualization(
gz::math::Vector3d &_sensorSize,
double &_forceLength,
float &_cameraUpdateRate,
gz::math::Pose3f &_depthCameraOffset,
int &_visualizationResolution) :
gz::math::Pose3f &_depthCameraOffset) :
modelName(_modelName),
sensorSize(_sensorSize),
forceLength(_forceLength),
cameraUpdateRate(_cameraUpdateRate),
depthCameraOffset(_depthCameraOffset),
visualizationResolution(_visualizationResolution)
depthCameraOffset(_depthCameraOffset)
{
}

Expand Down
6 changes: 1 addition & 5 deletions src/systems/optical_tactile_plugin/Visualization.hh
Original file line number Diff line number Diff line change
Expand Up @@ -59,8 +59,7 @@ namespace optical_tactile_sensor
gz::math::Vector3d &_sensorSize,
double &_forceLength,
float &_cameraUpdateRate,
gz::math::Pose3f &_depthCameraOffset,
int &_visualizationResolution);
gz::math::Pose3f &_depthCameraOffset);

/// \brief Initialize the marker message representing the optical tactile
/// sensor
Expand Down Expand Up @@ -153,9 +152,6 @@ namespace optical_tactile_sensor
/// \brief Offset between depth camera pose and model pose
private: gz::math::Pose3f depthCameraOffset;

/// \brief Resolution of the sensor in pixels to skip.
private: int visualizationResolution;

/// \brief Whether the normal forces messages are initialized or not
private: bool normalForcesMsgsAreInitialized{false};
};
Expand Down
3 changes: 0 additions & 3 deletions test/integration/wheel_slip.cc
Original file line number Diff line number Diff line change
Expand Up @@ -240,7 +240,6 @@ TEST_F(WheelSlipTest, GZ_UTILS_TEST_DISABLED_ON_WIN32(TireDrum))
// const double kp = surfaceContactOde->GetElement("kp")->Get<double>();
// ASSERT_EQ(kp, 250e3);

double modelMass = 0.0;
for (const auto &linkName : linksToCheck)
{
Entity linkEntity = ecm->EntityByComponents(
Expand All @@ -251,8 +250,6 @@ TEST_F(WheelSlipTest, GZ_UTILS_TEST_DISABLED_ON_WIN32(TireDrum))
auto inertialComp = ecm->Component<components::Inertial>(linkEntity);

EXPECT_NE(nullptr, inertialComp);

modelMass += inertialComp->Data().MassMatrix().Mass();
}

// Get axle wheel and steer joint of wheel model
Expand Down