Fix component removal in component inspector #1833
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
🦟 Bug fix
Summary
When clicking an object, the components of the previously selected objects get removed from the component inspector view. From example, if the world is currently selected, clicking on a model would remove the gravity component from the view. The mechanism that makes it work was broken when
gz
was removed fromQ_ARG(sim::ComponentTypeId, typeId));
ofgz-sim/src/gui/plugins/component_inspector/ComponentInspector.cc
Line 922 in 60d4121
We used to need
invokeMethod
inUpdate
functions, but this is not the case anymore, so I went ahead and changed it to a regular function call.Checklist
codecheck
passed (See contributing)Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining
Signed-off-by
messages.