Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix component removal in component inspector #1833

Merged
merged 1 commit into from
Dec 7, 2022

Conversation

azeey
Copy link
Contributor

@azeey azeey commented Dec 6, 2022

🦟 Bug fix

Summary

When clicking an object, the components of the previously selected objects get removed from the component inspector view. From example, if the world is currently selected, clicking on a model would remove the gravity component from the view. The mechanism that makes it work was broken when gz was removed from Q_ARG(sim::ComponentTypeId, typeId)); of

Q_ARG(sim::ComponentTypeId, typeId));
in #1794. This was also generating the warning:

[GUI] [Wrn] [Application.cc:845] [QT] QMetaObject::invokeMethod: No such method gz::sim::ComponentsModel::RemoveComponentType(gz::sim::ComponentTypeId)
Candidates are:
    RemoveComponentType(sim::ComponentTypeId)

We used to need invokeMethod in Update functions, but this is not the case anymore, so I went ahead and changed it to a regular function call.

Checklist

  • Signed all commits for DCO
  • Added tests
  • Updated documentation (as needed)
  • Updated migration guide (as needed)
  • Consider updating Python bindings (if the library has them)
  • codecheck passed (See contributing)
  • All tests passed (See test coverage)
  • While waiting for a review on your PR, please help review another open pull request to support the maintainers

Note to maintainers: Remember to use Squash-Merge and edit the commit message to match the pull request summary while retaining Signed-off-by messages.

@azeey azeey requested a review from mjcarroll as a code owner December 6, 2022 22:43
@github-actions github-actions bot added the 🌱 garden Ignition Garden label Dec 6, 2022
@mjcarroll mjcarroll merged commit 64c01fd into gazebosim:gz-sim7 Dec 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🌱 garden Ignition Garden
Projects
Archived in project
Development

Successfully merging this pull request may close these issues.

3 participants