port: 6 to 7 20221111

[nkoenig]

➡️ Forward port

Port ign-gazebo6 to gz-sim7.

Most of the changes are ign->gz naming updates. Here is a list of files that contain changes other changes:

1. Changelog.md
2. examples/worlds/tunnel.sdf
3. src/systems/rf_comms/RFComms.cc
4. test/integration/hydrodynamics.cc
5. test/worlds/hydrodynamics.sdf

@azeey and/or @scpeters can you take a look at the Physics system. I combined the merge, which I think is making the tests upset.

@caguero , can you give the thruster changes a look?

Branch comparison: https://github.com/gazebosim//compare/<TO_BRANCH>...<FROM_BRANCH>

Note to maintainers: Remember to Merge with commit (not squash-merge or rebase)

[codecov]

Codecov Report

Merging #1794 (90eb788) into gz-sim7 (6a8594b) will increase coverage by 0.03%.
The diff coverage is 64.84%.

❗ Current head 90eb788 differs from pull request most recent head 6c45078. Consider uploading reports for the commit 6c45078 to get more accurate results

@@             Coverage Diff             @@
##           gz-sim7    #1794      +/-   ##
===========================================
+ Coverage    64.16%   64.19%   +0.03%     
===========================================
  Files          335      336       +1     
  Lines        26508    26916     +408     
===========================================
+ Hits         17008    17278     +270     
- Misses        9500     9638     +138     

Impacted Files	Coverage Δ
include/gz/sim/SystemLoader.hh	100.00% <ø> (ø)
include/gz/sim/detail/EntityComponentManager.hh	93.86% <ø> (ø)
include/gz/sim/rendering/RenderUtil.hh	100.00% <ø> (ø)
src/gui/GuiFileHandler.cc	0.00% <0.00%> (ø)
.../plugins/component_inspector/ComponentInspector.hh	28.57% <ø> (ø)
src/gui/plugins/scene_manager/GzSceneManager.cc	17.58% <0.00%> (-0.60%)	⬇️
...rc/systems/ackermann_steering/AckermannSteering.hh	100.00% <ø> (ø)
src/systems/altimeter/Altimeter.cc	75.00% <ø> (-0.29%)	⬇️
src/systems/battery_plugin/LinearBatteryPlugin.cc	73.20% <ø> (ø)
src/systems/detachable_joint/DetachableJoint.cc	70.66% <ø> (ø)
... and 64 more

Help us with your feedback. Take ten seconds to tell us how you rate us. Have a feature suggestion? Share it here.

[caguero]

I tested my code that uses thrusters and seems to work. I just noticed a warning that didn't see in the previous branch (6-to-7-20221021):

[ruby $(which gz) sim-1] [Err] [SDFFeatures.cc:320] Mesh construction from an SDF has not been implemented yet for dartsim.
[ruby $(which gz) sim-1] [Err] [SDFFeatures.cc:787] The geometry element of collision [collision] couldn't be created

[caguero]

I tested my code that uses thrusters and seems to work. I just noticed a warning that didn't see in the previous branch (6-to-7-20221021):

[ruby $(which gz) sim-1] [Err] [SDFFeatures.cc:320] Mesh construction from an SDF has not been implemented yet for dartsim.
[ruby $(which gz) sim-1] [Err] [SDFFeatures.cc:787] The geometry element of collision [collision] couldn't be created

This is coming from gz-physics, so probably unrelated due to a vcs pull.

[scpeters]

I just restarted the windows CI job after wiping the workspace

I think the commit history would be a little tidier if all the commits responding to PR feedback were squashed into 878625d

[mjcarroll]

I think the commit history would be a little tidier if all the commits responding to PR feedback were squashed

Agree, otherwise looks good to me.

[nkoenig]

I squashed the commits down into 78b6699, but was unable to figure out how to squash them into 878625d. I was using the rebase command.

[azeey]

The physics system looks good. I only saw namespace changes.

To squash into 878625d, I think you can do

git reset --soft 878625d
git commit --amend

[nkoenig]

The physics system looks good. I only saw namespace changes.

To squash into 878625d, I think you can do

git reset --soft 878625d
git commit --amend

Thanks.

[nkoenig]

The failing tests are all related to fuelserver timeouts.