Disable rendering tests on macOS that are known to fail #209
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Addisu Z. Taddese <[email protected]>
chapulina
added
rendering
|
I think it would be good to release gazebosim/gz-cmake#102 and use that here. |
…ering_tests_macos
Signed-off-by: Addisu Z. Taddese <[email protected]>
chapulina
approved these changes
Aug 15, 2020
There was a problem hiding this comment.
There is an effort to address this from the ign-rendering side in ign-rendering#83
That was merged, but I don't think that affects ign-gazebo tests: gazebosim/gz-rendering#83.
This PR LGTM, but note that there are more failing tests on macOS.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Tests that use OGRE2 rending have been failing on macOS for a long time. There is an effort to address this from the ign-rendering side in ign-rendering#83, but until that is merged, I thought we should disable these tests. I used gtests ability to disable tests by prepending
DISABLED_to the test name so that the tests are compiled, but they won't be ran.